Skip to content

Add more information for the SSL erros #4278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabriel-bolbotina wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add more information for the SSL erros #4278

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bb5d46
Added ssl error logging in mergin api
gabriel-bolbotina Jan 8, 2026
6472932
Updated implementation
gabriel-bolbotina Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions core/merginapi.cpp
View file
Open in desktop
Copy link
Contributor

@Withalion Withalion Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we can also connect to the same signal on the level of QNetworkAccessManager, see here. It would be better to attach to it in the constructor of MerginApi and listen to every request not just pingMergin.

Also logging the error description and which reply it is attached to seems enough to me, no need to dump the whole cert info.

Original file line number Diff line number Diff line change
Expand Up @@ -1887,6 +1887,27 @@ void MerginApi::pingMergin()
request.setUrl( url );

QNetworkReply *reply = mManager->get( request );
#ifndef QT_NO_SSL
connect( reply, &QNetworkReply::sslErrors, this, [url]( const QList<QSslError> &errors )
{
CoreUtils::log( "URL attempting to access:", url.toString() );
for ( const auto &error : errors )
{
CoreUtils::log( "Error Description:", error.errorString() );
// Get the certificate causing the error
QSslCertificate cert = error.certificate();
if ( !cert.isNull() )
{
CoreUtils::log( "Subject (Common Name):", cert.subjectInfo( QSslCertificate::CommonName ).join( "," ) );
CoreUtils::log( "Issuer (Common Name):", cert.issuerInfo( QSslCertificate::CommonName ).join( "," ) );
CoreUtils::log( "Organization:", cert.subjectInfo( QSslCertificate::Organization ).join( "," ) );
CoreUtils::log( "Valid From:", cert.effectiveDate().toString() );
CoreUtils::log( "Expires On:", cert.expiryDate().toString() );
CoreUtils::log( "Fingerprint (SHA256):", cert.digest( QCryptographicHash::Sha256 ).toHex() );
}
}
} );
#endif
CoreUtils::log( "ping", QStringLiteral( "Requesting: " ) + url.toString() );
connect( reply, &QNetworkReply::finished, this, &MerginApi::pingMerginReplyFinished );
}
Expand Down
Loading