chore: correct stale exports comment - #10244
Closed
cryptodev-2s wants to merge 2 commits into
Closed
cryptodev-2s wants to merge 2 commits into
cryptodev-2s wants to merge 2 commits into
Conversation
Mrtenz
approved these changes
Sep 16, 2026
Mrtenz
requested changes
Sep 16, 2026
Mrtenz
left a comment
Member
There was a problem hiding this comment.
This comment is accurate actually.
Mrtenz
reviewed
Sep 16, 2026
Comment on lines
+171
to
+172
| // All non-root packages must set up ESM-only exports correctly (aside | ||
| // from tools). |
Member
There was a problem hiding this comment.
It would be ESM-only if we used exports.import.types/default. exports.types/default keeps it possible to use require(esm) in CommonJS mode.
Member
There was a problem hiding this comment.
I mean, the original comment is fine as-is, no?
Contributor
Author
There was a problem hiding this comment.
You're right I did miss interpreted this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The comment above
expectCorrectWorkspaceExportssays packages set up "ESM- and CommonJS-compatible exports", but the function it introduces asserts the opposite:References
Part of WPC-1161.
Checklist
Note
Low Risk
Comment-only change to Yarn constraint documentation; no enforcement logic or package manifests are modified.
Overview
Updates the Yarn constraints comment above
expectCorrectWorkspaceExportsso it matches what the rule actually checks.The old wording implied packages should configure ESM- and CommonJS-compatible
exports; the constraint instead requires a single unconditional entrypoint (exports["."].types/default) and explicitly disallows separaterequire/importconditions plus legacymain/types. No runtime or manifest behavior changes—documentation only inyarn.config.cjs.Reviewed by Cursor Bugbot for commit 7eb228e. Bugbot is set up for automated code reviews on this repo. Configure here.