feat: check against urls with path #6416
Open
+996
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ) => { | ||
| const urlWithProtocol = url.startsWith('http') ? url : `https://${url}`; | ||
| const { hostname, pathname } = new URL(urlWithProtocol); | ||
| const pathComponents = pathname.split('/').filter(Boolean); |
There was a problem hiding this comment.
Bug: Inconsistent URL Handling Causes Crashes
The removeURLFromBlocklistPaths and doesURLPathExist functions directly use new URL(), which throws exceptions for invalid URLs. This is inconsistent with addURLToBlocklistPaths's use of the newURL helper, which gracefully returns null. This difference in error handling could lead to application crashes when processing malformed URLs.
Additional Locations (1)
| // Level 4: remaining path segments | ||
| if (remainingPaths.length === 0) { | ||
| return true; // Exact match at 3-segment level | ||
| } |
There was a problem hiding this comment.
Bug: URL Path Existence Bug
The doesURLPathExist function incorrectly returns true for URLs with exactly three path components. This happens when the blocklist entry for the third path component contains specific deeper paths, implying the three-segment path itself is not blocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist