feat: use QuoteResponse V2 in bridge-controller - #9726
Open
micaelae wants to merge 19 commits into
Open
Conversation
micaelae
changed the base branch from
swaps4546-v2-coercers
to
swaps4546-v2-metadata
July 31, 2026 04:06
Member
Author
|
@metamaskbot publish-preview |
micaelae
changed the title
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
micaelae
changed the title
micaelae
marked this pull request as ready for review
August 4, 2026 16:38
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2d0732a. Configure here.
| QuoteStreamCompleteReason, | ||
| } from './validators/quote-stream-complete.js'; | ||
| export { BatchSellTransactionType } from './validators/batch-sell.js'; | ||
| export { type AmountsAndAssetSchema } from './validators/amount-and-asset.js'; |
There was a problem hiding this comment.
Schema exported as type-only
Medium Severity
AmountsAndAssetSchema is a runtime Superstruct schema, but it is exported with type, so importers only get a type and cannot use the schema for validation at runtime. Sibling schemas like BridgeAssetSchema are exported as values.
Reviewed by Cursor Bugbot for commit 2d0732a. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Store and consume QuoteResponse v2 in the bridge-controller. Implements v1<>v2 coercers and metadata merge logic for client and controller compatibility during migration. See changelogs for more details
Draft client PRs
References
Checklist
Note
High Risk
Breaking type and behavior changes across quote fetching, fee attachment, selectors, and tx submission paths for unified swap/bridge and batch-sell; consumers must adopt V2 or use coercers.
Overview
BREAKING:
BridgeControllerstate, quote streaming, and publicQuoteResponsetyping now use QuoteResponse V2 (V1 remains asQuoteResponseV1). Incoming SSE/API payloads are coerced withtoQuoteResponseV2; batch gasless calls still post V1 viatoQuoteResponseV1.appendFeesToQuotesnow takes a CAIPchainIdfirst and skips fee enrichment when a fetch has multiple source chains. Selectors, metrics, and batch-sell rollups are updated for the V2 quote shape (quote.src/quote.dest, top-levelchainId,sumAmountsfor totals).bridge-status-controllersubmitTx/submitIntent/submitBatchSellaccept V2 quotes from clients but normalize to V1 before internal submission and history.Reviewed by Cursor Bugbot for commit 2d0732a. Bugbot is set up for automated code reviews on this repo. Configure here.