Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gh-pages to receive chainId, update Ledger library to 6.5.0 #95

Merged
merged 9 commits into from
Aug 30, 2021
Merged

Update gh-pages to receive chainId, update Ledger library to 6.5.0 #95

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
16dc9c3
Update gh-pages to receive chainId, update Ledger library to 6.4.1
darkwing Aug 16, 2021
c52a836
Add safety so that old and new lookup work properly
darkwing Aug 16, 2021
5903a8a
Address feedback: check for chainId
darkwing Aug 17, 2021
28c98a6
Pin to specific version to avoid semver issues
darkwing Aug 17, 2021
12f36c5
v6.5.0 bycontractaddress removal
danjm Aug 25, 2021
6f6b7cd
Removed unused import
danjm Aug 25, 2021
9ca46a3
Specificy npm v7.6.1 in engines property of package.json
danjm Aug 26, 2021
190893e
Update lockfile
Gudahtt Aug 26, 2021
231bd5d
Remove unused parameter from signTransaction in ledger-bridge
danjm Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38,842 changes: 33,025 additions & 5,817 deletions bundle.js
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 0 additions & 5 deletions ledger-bridge.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ require('buffer')

import TransportU2F from '@ledgerhq/hw-transport-u2f'
import LedgerEth from '@ledgerhq/hw-app-eth'
import { byContractAddress } from '@ledgerhq/hw-app-eth/erc20'
import WebSocketTransport from '@ledgerhq/hw-transport-http/lib/WebSocketTransport'

// URL which triggers Ledger Live app to open and handle communication
Expand Down Expand Up @@ -143,10 +142,6 @@ export default class LedgerBridge {
async signTransaction (replyAction, hdPath, tx, to) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The to parameter is now unused

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in 231bd5d

try {
await this.makeApp()
if (to) {
const isKnownERC20Token = byContractAddress(to)
Gudahtt marked this conversation as resolved.
Show resolved Hide resolved
if (isKnownERC20Token) await this.app.provideERC20TokenInformation(isKnownERC20Token)
}
const res = await this.app.signTransaction(hdPath, tx)
this.sendMessageToExtension({
action: replyAction,
Expand Down
Loading