feat(stellar-wallet-snap): use shared urlstruct - #190
Merged
Julink-eth merged 4 commits intoAug 25, 2026
Conversation
stanleyyconsensys
approved these changes
Aug 25, 2026
stanleyyconsensys
left a comment
Contributor
There was a problem hiding this comment.
Approved , but plz do a publish preview to validate if you didnt
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Julink-eth
deleted the
feat/WPN-1890-use-shared-urlstruct-in-stellar-snap
branch
August 25, 2026 12:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Replace the Stellar snap's local
UrlStructwith the shared one from@metamask/snap-networks-utils, matching Solana and Tron.config,buildUrl,PriceApiClient,SecurityAlertsApiClient, token-api structs) importUrlStructfrom@metamask/snap-networks-utils.src/api/url.tsandurl.test.tsare removed; validation lives in the shared package.@metamask/snap-networks-utilsand a tsconfig project reference.References
Checklist