Skip to content

feat(stellar-wallet-snap): use shared urlstruct - #190

Merged
Julink-eth merged 4 commits into
mainfrom
feat/WPN-1890-use-shared-urlstruct-in-stellar-snap
Aug 25, 2026
Merged

feat(stellar-wallet-snap): use shared urlstruct#190
Julink-eth merged 4 commits into
mainfrom
feat/WPN-1890-use-shared-urlstruct-in-stellar-snap

Conversation

@Julink-eth

Copy link
Copy Markdown
Contributor

Explanation

Replace the Stellar snap's local UrlStruct with the shared one from @metamask/snap-networks-utils, matching Solana and Tron.

  • Call sites (config, buildUrl, PriceApiClient, SecurityAlertsApiClient, token-api structs) import UrlStruct from @metamask/snap-networks-utils.
  • Local src/api/url.ts and url.test.ts are removed; validation lives in the shared package.
  • Adds @metamask/snap-networks-utils and a tsconfig project reference.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@Julink-eth
Julink-eth requested review from a team as code owners August 25, 2026 10:10
@Julink-eth
Julink-eth deployed to default-branch August 25, 2026 10:10 — with GitHub Actions Active

@stanleyyconsensys stanleyyconsensys left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved , but plz do a publish preview to validate if you didnt

@Julink-eth

Copy link
Copy Markdown
Contributor Author

@metamaskbot publish-preview

@stanleyyconsensys stanleyyconsensys changed the title feat: use shared urlstruct instead of the local one in Stellar snap feat(stellar-wallet-snap): use shared urlstruct instead of the local one in Stellar snap Aug 25, 2026
@stanleyyconsensys stanleyyconsensys changed the title feat(stellar-wallet-snap): use shared urlstruct instead of the local one in Stellar snap feat(stellar-wallet-snap): use shared urlstruct Aug 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/bitcoin-wallet-snap@2.0.1-preview-26d6c588
@metamask-previews/snap-networks-utils@1.0.0-preview-26d6c588
@metamask-previews/solana-wallet-snap@6.0.0-preview-26d6c588
@metamask-previews/stellar-wallet-snap@0.1.0-preview-26d6c588
@metamask-previews/tron-wallet-snap@3.1.0-preview-26d6c588

@Julink-eth
Julink-eth added this pull request to the merge queue Aug 25, 2026
Merged via the queue into main with commit a74a2eb Aug 25, 2026
53 checks passed
@Julink-eth
Julink-eth deleted the feat/WPN-1890-use-shared-urlstruct-in-stellar-snap branch August 25, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants