refactor(solana-wallet-snap): extract SnapAssetsAdapter for Solana balance reads - #121
Draft
ulissesferreira wants to merge 3 commits into
Conversation
…ks-utils Add getAccountAssetByID, getAccountAssetsByIDs, getAccountAssetsByScope, and getAccountAssetsForAllActiveScopes. Update Keyring, Send, send render, and refreshSend to use the new API. No behavior change — still reads from Snap-owned assetEntities via AssetsRepository. Migrated from MetaMask/snap-solana-wallet#635. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
Move balance fetch/persist/read logic into SnapAssetsAdapter. AssetsService delegates to a single adapter — no Core routing yet. Migrated from MetaMask/snap-solana-wallet#636. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>
4 tasks
cursor
Bot
force-pushed
the
ulissesferreira/wpn-1652-align-assets-service-api-6620
branch
from
August 5, 2026 18:09
f5ec399 to
ed3340c
Compare
ulissesferreira
changed the title
cursor
Bot
force-pushed
the
ulissesferreira/wpn-1652-align-assets-service-api-6620
branch
3 times, most recently
from
August 6, 2026 15:18
11fe525 to
eef1038
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Part of migrating the Solana assets-controller staged migration from snap-solana-wallet#636 into this monorepo (PR 2 of 6, Lane A / feature-flag path only).
adapters/SnapAssetsAdapter.tsAssetsServicebecomes a thin facade that delegates account asset reads/saves to the adapterAssetsServicefor nowReferences
AssetsProviderwiring (Tron-style, not literalCoreAssetsAdapter)Checklist