fix: Prevent infinite recursion in crypto.subtle polyfill - #133
Merged
Conversation
ulissesferreira
approved these changes
Aug 6, 2026
Contributor
|
Tested with chrome extensiox on main branch. accounts generation and addresses - ok. |
taran-a
approved these changes
Aug 6, 2026
FrederikBolding
marked this pull request as ready for review
August 6, 2026 14:36
FrederikBolding
temporarily deployed
to
default-branch
August 6, 2026 14:36 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The
ed25519polyfill in the Solana Snap is broken when anything but theed25519algorithm is used. This prevents us from using the newest version ofkey-treewhich has a bunch of performance improvements.This PR corrects the polyfill so it no longer infinitely recurses and bumps
key-treeback to the latest version.