refactor(solana-wallet-snap): remove asset pubkeys - #245
Open
ulissesferreira wants to merge 3 commits into
Open
ulissesferreira wants to merge 3 commits into
ulissesferreira wants to merge 3 commits into
Conversation
ulissesferreira
marked this pull request as draft
September 1, 2026 11:31
ulissesferreira
force-pushed
the
solana-remove-asset-pubkey
branch
from
September 3, 2026 16:46
82ec651 to
1c9dae3
Compare
stanleyyconsensys
marked this pull request as ready for review
September 7, 2026 03:00
stanleyyconsensys
marked this pull request as draft
September 7, 2026 03:00
ulissesferreira
force-pushed
the
solana-remove-asset-pubkey
branch
from
September 17, 2026 10:12
de4c2c1 to
7158271
Compare
ulissesferreira
force-pushed
the
solana-remove-asset-pubkey
branch
from
September 17, 2026 10:25
7158271 to
55feb55
Compare
|
ulissesferreira
marked this pull request as ready for review
September 17, 2026 12:39
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
We will take 1 step backwards so we can then take 2 steps forward. We need to stop storing a field that the AssetsController can't return. We might lose some performance out of transaction history fetching but this will soon not be a problem when we start getting transaction history from controllers too.
pubkeyfrom the SolanaTokenAssetandNftAssetmodels.Validation
packages/solana-wallet-snap/dist/bundle.js; the local build is also blocked by the current workspace package-resolution state for@metamask/snap-networks-utils.This PR is based on the latest
origin/main.