Conversation
64d882d to
0ee19c8
Compare
9e5e284 to
2a29870
Compare
04dac8c to
d72d8dc
Compare
2a29870 to
12b8da5
Compare
12b8da5 to
dd29022
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
May it worth to check if Sonar Coverage could reach the 100% with this file |
There was a problem hiding this comment.
🟡 Changes recommended
Consumer-facing changes need changelog entries, and the new address-type validation needs direct coverage.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Migrates Bitcoin Snap configuration to shared validated configuration utilities.
Changes:
- Adds and exports a reusable defaulted URL struct.
- Validates Bitcoin Snap environment configuration at startup.
- Updates consumers, tests, and documented logging defaults.
File summaries
| File | Description |
|---|---|
packages/snap-networks-utils/src/utils/config/envStructs.ts |
Adds defaulted URL validation. |
packages/snap-networks-utils/src/utils/config/envStructs.test.ts |
Tests URL parsing and defaults. |
packages/snap-networks-utils/src/index.ts |
Exports the new utility. |
packages/bitcoin-wallet-snap/src/config.ts |
Defines validated configuration. |
packages/bitcoin-wallet-snap/src/config.test.ts |
Tests configuration behavior. |
packages/bitcoin-wallet-snap/src/index.ts |
Uses the shared provider. |
packages/bitcoin-wallet-snap/src/utils/logger.ts |
Reads validated log configuration. |
packages/bitcoin-wallet-snap/src/infra/jsx/send-flow/ReviewTransactionView.tsx |
Reads confirmation configuration. |
packages/bitcoin-wallet-snap/.env.example |
Documents the new logging default. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 4
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
@metamaskbot publish-preview |
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |



Explanation
Migrate the Bitcoin snap to the shared config provider pattern. This snap previously had no env validation — malformed values were used silently.
References
Checklist