feat: stellar memo confirm UI by khanti42 · Pull Request #323 · MetaMask/internal-snaps

khanti42 · 2026-09-17T08:33:41Z

Explanation

Today, when a Stellar send destination requires a memo (SEP-29 RequiresMemo), validation fails before the user can fix it in the send confirmation UI. There is no way to open a draft confirmation, edit a memo, and continue to a successful rebuild/sign.

This PR adds the confirm-UI recovery path on top of memo attach (#289) and recoverable refresh (#291):

Note: includes #291 + confirm UI; #289 already on main.

Screen.Recording.2026-09-17.at.10.36.22.mov

On RequiresMemo, rebuild a draft send with skipMemoRequirementCheck: true and open the confirmation dialog with a banner / Add–Update memo flow (MemoEdit).
Store the memo on confirmation context (context.memo), not on client confirmSend wire params (memo / memoType).
Dialog resolves as { confirmed, memo? }. Live refresh treats RequiresMemo as recoverable so saving a memo can restart validation/security scanning without nulling securityScanRequest.
After confirm, re-validate with the memo attached (memo check enforced again) before signing. Confirming without a memo still fails as invalid.

Memo resolution uses resolveStellarMemo from the attach path: all-digit uint64 → memo id, otherwise text (≤ 28 UTF-8 bytes). Draft UI validation follows the same rules via getMemoDraftValidationError in api/memo.

Depends on / must land after: #289 (memo attach / resolveStellarMemo) and #291 (recoverable confirmation refresh). This PR merges both and adds the UI + context.memo wiring.

References

Requirements

Related to WPN-2033 / WPN-2034 (SEP-29 memo recovery)

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed
I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

…path

… const

…t and refactoring

…tion handler

…and attach resolved Stellar memos on send build path

…nd migrate resolution to TransactionService

…llar-memo-confirm-ui

…t and removing legacy RPC support

…ation, and support numeric memos in UI

…mo validation

…m-ui

sonarqubecloud · 2026-09-17T11:13:40Z

Quality Gate failed

Failed conditions
53.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

khanti42 · 2026-09-17T11:26:31Z

+   * When true, SEP-29 memo-required checks are skipped during local simulation.
+   * Used to build a draft envelope for a recoverable RequiresMemo confirmation.
+   */
+  skipMemoRequirementCheck?: boolean;


see comment above

khanti42 · 2026-09-17T11:29:48Z

 ): Promise<void> {
  const { id } = options;
-  await resolveInterface(id, false);
+  await resolveInterface(id, { confirmed: false });


We don't keep a boolean and read memo from context after resolve because after resolveInterface, the dialog is done; pulling memo from context again is awkward with the snaps interface lifecycle. Returning memo in the resolve payload is more straightforward handoff to confirmSend.

Why not put memo on confirmSend RPC params?
Memo is UI-owned for SEP-29 recovery (add/edit in the dialog). We deliberately don’t add client wire memo / memoType.

So: object result = confirm + optional memo in one shot; cancel uses the same shape for consistency.

khanti42 · 2026-09-17T11:32:18Z

   * @param params.destination - The destination address.
   * @param params.destinationAccount - The destination account.
   * @param params.memo - Optional Stellar memo value to attach to the envelope.
+   * @param params.skipMemoRequirementCheck - When true, skips SEP-29 memo-required checks.


Before this PR, a send to a SEP-29 memo-required destination with no memo failed validation and opened a dismiss-only error confirmation — user couldn’t fix the memo in-flow.

We still need a built envelope to open the normal send confirm (fees, scan, etc.). So after RequiresMemoException, confirmSend rebuilds once with skipMemoRequirementCheck: true to skip only the memo-required check and open a recoverable confirm with Add/Update memo.

That flag is not used for signing. After the user adds a memo (context.memo), refresh / post-confirm rebuild run without the flag so SEP-29 is enforced again before sign.

…ror handling tests

stanleyyconsensys

left batch 1 comments

stanleyyconsensys · 2026-09-17T12:00:57Z

+ * @param value - Raw draft from the confirmation UI (may include whitespace).
+ * @returns Locale error key, or `null` when empty/whitespace or valid.
+ */
+export function getMemoDraftValidationError(


not sure if we should put it here, it is similar to resolveStellarMemo

stanleyyconsensys · 2026-09-17T12:09:17Z

+   * @returns The transaction and whether memo recovery UI should be shown.
+   * @throws {UserRejectedRequestError} After the pre-submit error dialog is dismissed.
+   */
+  async #buildSendTransactionForConfirm(params: {


i think it is a bit repeat

all we wanna is to skip memo require at first time

and then return to caller , we need memo

why not just skip it and build it

and then use assertMemoWhenDestinationRequires to validate ?

stanleyyconsensys · 2026-09-17T12:10:38Z

+      if (requiresMemoRecovery && !confirmedMemo) {
+        return {
+          valid: false,
+          errors: [{ code: MultiChainSendErrorCodes.Invalid }],
+        };
+      }


you dont need it, refreshTransactionAfterConfirmation will do the job

Suggested change

if (requiresMemoRecovery && !confirmedMemo) {

return {

valid: false,

errors: [{ code: MultiChainSendErrorCodes.Invalid }],

};

}

stanleyyconsensys · 2026-09-17T12:16:11Z

+      const trimmedMemo = dialogResult.memo?.trim();
+      const confirmedMemo = trimmedMemo === '' ? undefined : trimmedMemo;


nit:

|| allow "" to undefined
?? not allow

Suggested change

const trimmedMemo = dialogResult.memo?.trim();

const confirmedMemo = trimmedMemo === '' ? undefined : trimmedMemo;

const trimmedMemo = dialogResult.memo?.trim() || undefined

stanleyyconsensys · 2026-09-17T12:20:38Z

+        // Keep the original request so Add/Update memo still works on this
+        // dead-end validation dialog (no localSimulation / refresh).
+        request,


display error is not necessary to own the request, becoz we skip the memo error , this displayDialogWithErrorMessage only handle non-memo error

stanleyyconsensys · 2026-09-17T12:23:42Z

    assetId: KnownCaip19AssetIdOrSlip44Id;
    destination: string;
    memo?: string;
+    skipMemoRequirementCheck?: boolean;


i would prefer

skipExceptions: TransactionValidationException[]

it is more flexible

…MemoRequirementCheck

khanti42 added 21 commits September 8, 2026 15:07

feat(stellar-wallet-snap): attach optional memo on confirmSend build …

65de044

…path

feat(stellar-wallet-snap): add recoverable confirmation refresh outcome

3742e56

refactor(stellar-wallet-snap): drop unused StellarTextMemoStruct

acea5e1

chore: lint

1c14e23

refactor(stellar-wallet-snap): derive memo type from StellarMemoTypes…

2460944

… const

refactor(stellar-wallet-snap): use StellarMemoType const with Infer type

c0f3d02

feat(stellar-wallet-snap): update memo handling to support wire forma…

c8e4ff6

…t and refactoring

refactor: combine halt and recoverable conditions in refresh confirma…

b7ad332

…tion handler

chore: lint

63c15ad

test: add memo validation and integration tests for stellar-wallet-snap

7d7d9aa

chore: update CHANGELOG.md

4561583

feat(stellar-wallet-snap): add optional memo/memoType to confirmSend …

f839635

…and attach resolved Stellar memos on send build path

chore: lint

5a4f08e

refactor: remove client-side memo and memoType from confirmSend API a…

b625a99

…nd migrate resolution to TransactionService

Merge branch 'feat/stellar-confirm-recoverable-refresh' into feat/ste…

053571f

…llar-memo-confirm-ui

feat: implement recoverable memo editing for Stellar send confirmations

942ee3f

feat: simplify Stellar wallet memo handling by enforcing 28-byte limi…

98f7d9c

…t and removing legacy RPC support

feat(wallet-snap): enforce uint64 range for memo IDs, add draft valid…

f80dcd9

…ation, and support numeric memos in UI

refactor: infer stellar memo type automatically and simplify validation

c7605f2

refactor: replace superstruct with predicate functions for stellar me…

d931ae9

…mo validation

Merge branch 'feat/stellar-memo-attach' into feat/stellar-memo-confir…

3728f61

…m-ui

khanti42 changed the title ~~Feat/stellar memo confirm UI~~ feat: stellar memo confirm UI Sep 17, 2026

khanti42 added 2 commits September 17, 2026 12:54

Merge branch 'main' into feat/stellar-memo-confirm-ui

4e2cec1

chore: lint

fa14024

khanti42 commented Sep 17, 2026

View reviewed changes

refactor: extract send transaction logic for memo recovery and add er…

e73c4e3

…ror handling tests

stanleyyconsensys reviewed Sep 17, 2026

View reviewed changes

khanti42 added 3 commits September 18, 2026 00:04

refactor: remove RequiresMemoException by using draft build with skip…

8c3b549

…MemoRequirementCheck

refactor: clean-up

4456b86

refactor: skipMemoRequirementCheck -> skipExceptions[]

d7fc796

khanti42 force-pushed the feat/stellar-memo-confirm-ui branch from 0d0005c to d7fc796 Compare September 17, 2026 23:18

stanleyyconsensys marked this pull request as ready for review September 18, 2026 02:01

stanleyyconsensys requested a review from a team as a code owner September 18, 2026 02:01

stanleyyconsensys deployed to default-branch September 18, 2026 02:01 — with GitHub Actions Active

Navigation Menu

feat: stellar memo confirm UI - #323

feat: stellar memo confirm UI#323
khanti42 wants to merge 27 commits into
mainfrom
feat/stellar-memo-confirm-ui

khanti42 commented Sep 17, 2026 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Sep 17, 2026

Uh oh!

khanti42 Sep 17, 2026 •

edited

Loading

Uh oh!

khanti42 Sep 17, 2026

Uh oh!

khanti42 Sep 17, 2026

Uh oh!

stanleyyconsensys left a comment

Uh oh!

stanleyyconsensys Sep 17, 2026

Uh oh!

stanleyyconsensys Sep 17, 2026

Uh oh!

stanleyyconsensys Sep 17, 2026

Uh oh!

stanleyyconsensys Sep 17, 2026

Uh oh!

stanleyyconsensys Sep 17, 2026

Uh oh!

stanleyyconsensys Sep 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		const trimmedMemo = dialogResult.memo?.trim();
		const confirmedMemo = trimmedMemo === '' ? undefined : trimmedMemo;

Conversation

khanti42 commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

References

Checklist

Uh oh!

sonarqubecloud Bot commented Sep 17, 2026

Quality Gate failed

Uh oh!

khanti42 Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stanleyyconsensys left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

khanti42 commented Sep 17, 2026 •

edited

Loading

khanti42 Sep 17, 2026 •

edited

Loading