Skip to content

Commit

Permalink
chore: renaming tsconfig.packages.build.jsonc to tsconfig.packages.bu…
Browse files Browse the repository at this point in the history
…ild.json (#67)

## **Description**

This PR renames the file `tsconfig.packages.build.jsonc` to
`tsconfig.packages.build.json` and removes the `types` folder, which was
a leftover from core monorepo configuration. This json change aligns
with the configuration structure in the Snaps and Core monorepos. There
were comments in some configuration JSON files, and it appears these
comments do not cause any issues.

## **Related issues**

Fixes:

- Issue # (if applicable)

## **Manual testing steps**

1. Verify the renamed `tsconfig.packages.build.json` file loads
correctly in the project.
2. Ensure the removal of the `types` folder does not cause build issues.
3. Validate that other JSON configuration files work as expected without
the comments.
4. Run a full build and test to confirm there are no breaking changes.

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs)
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test the code).
- [ ] This PR satisfies all acceptance criteria and includes necessary
testing evidence (e.g., recordings or screenshots).
  • Loading branch information
georgewrmarshall authored Oct 29, 2024
1 parent 8679ec8 commit ae286e2
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions packages/design-system-react-native/tsconfig.build.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"extends": "../../tsconfig.packages.build.jsonc",
"extends": "../../tsconfig.packages.build.json",
"compilerOptions": {
"baseUrl": "./",
"outDir": "./dist",
"rootDir": "./src"
},
"references": [],
"include": ["../../types", "./src"]
"include": ["./src"]
}
2 changes: 1 addition & 1 deletion packages/design-system-react-native/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"baseUrl": "./"
},
"references": [],
"include": ["../../types", "./src"]
"include": ["./src"]
}
4 changes: 2 additions & 2 deletions packages/design-system-tailwind-preset/tsconfig.build.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
{
"extends": "../../tsconfig.packages.build.jsonc",
"extends": "../../tsconfig.packages.build.json",
"compilerOptions": {
"baseUrl": "./",
"outDir": "./dist",
"rootDir": "./src",
"types": ["node"]
},
"references": [],
"include": ["../../types", "./src"]
"include": ["./src"]
}
4 changes: 2 additions & 2 deletions packages/metamask-module-template/tsconfig.build.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"extends": "../../tsconfig.packages.build.jsonc",
"extends": "../../tsconfig.packages.build.json",
"compilerOptions": {
"baseUrl": "./",
"outDir": "./dist",
"rootDir": "./src"
},
"references": [],
"include": ["../../types", "./src"]
"include": ["./src"]
}
2 changes: 1 addition & 1 deletion packages/metamask-module-template/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"baseUrl": "./"
},
"references": [],
"include": ["../../types", "./src"]
"include": ["./src"]
}
4 changes: 2 additions & 2 deletions scripts/create-package/package-template/tsconfig.build.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"extends": "../../tsconfig.packages.build.jsonc",
"extends": "../../tsconfig.packages.build.json",
"compilerOptions": {
"baseUrl": "./",
"outDir": "./dist",
"rootDir": "./src"
},
"references": [],
"include": ["../../types", "./src"]
"include": ["./src"]
}
2 changes: 1 addition & 1 deletion scripts/create-package/package-template/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"baseUrl": "./"
},
"references": [],
"include": ["../../types", "./src"]
"include": ["./src"]
}
File renamed without changes.

0 comments on commit ae286e2

Please sign in to comment.