Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSRN] Added AvatarFavicon #457

Merged
merged 4 commits into from
Feb 28, 2025
Merged

[DSRN] Added AvatarFavicon #457

merged 4 commits into from
Feb 28, 2025

Conversation

brianacnguyen
Copy link
Contributor

Description

This PR adds the AvatarFavicon component to DSRN.

Related issues

Fixes: #367

Manual testing steps

  1. Run yarn storybook:ios from root
  2. Go to Components > AvatarFavicon

Screenshots/Recordings

Before

After

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-02-27.at.16.03.35.mp4

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen requested a review from a team as a code owner February 28, 2025 00:10
@brianacnguyen brianacnguyen merged commit 5ea6eb3 into main Feb 28, 2025
30 checks passed
@brianacnguyen brianacnguyen deleted the dsrn/avatar-favicon branch February 28, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[React Native]: Create AvatarFavicon component in shared UI component library
2 participants