ci: a new prep-deps workflow with caching

.github/workflows/add-release-label.yml

@@ -12,14 +12,11 @@ jobs:
     runs-on: ubuntu-latest
     if: github.event.pull_request.merged == true
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
+      - name: Setup environment
+        uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
           fetch-depth: 0 # This is needed to checkout all branches
 
-      - name: Setup environment
-        uses: metamask/github-tools/.github/actions/setup-environment@main
-
       - name: Get the next semver version
         id: get-next-semver-version
         env:

.github/workflows/benchmarks.yml

@@ -15,11 +15,10 @@ jobs:
     container:
       image: cimg/node:22.13-browsers
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
       - name: Setup environment
-        uses: metamask/github-tools/.github/actions/setup-environment@benchmarks
+        uses: metamask/github-tools/.github/actions/setup-environment@caching
+        with:
+          should-cache-restore: ${{ vars.USE_CACHING }}
 
       - name: Download artifact prep-build-test-webpack
         uses: actions/download-artifact@v4

.github/workflows/build-beta.yml

@@ -42,7 +42,9 @@ jobs:
 
       - name: Setup environment
         if: ${{ steps.needs-beta-build.outputs.NEEDS_BETA_BUILD == 'true' }}
-        uses: metamask/github-tools/.github/actions/setup-environment@main
+        uses: metamask/github-tools/.github/actions/setup-environment@caching
+        with:
+          no-cache-for-release: 'true' # Turn off yarn cache as well
 
       - name: Run beta build
         if: ${{ steps.needs-beta-build.outputs.NEEDS_BETA_BUILD == 'true' }}

.github/workflows/build-storybook.yml

@@ -8,11 +8,10 @@ jobs:
     name: Build storybook
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
       - name: Setup environment
-        uses: metamask/github-tools/.github/actions/setup-environment@main
+        uses: metamask/github-tools/.github/actions/setup-environment@caching
+        with:
+          no-cache-for-release: 'true' # Turn off yarn cache as well
 
       - name: Build storybook
         run: yarn storybook:build

.github/workflows/check-attributions.yml

@@ -8,11 +8,8 @@ jobs:
   check-attributions:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
       - name: Setup environment
-        uses: metamask/github-tools/.github/actions/setup-environment@main
+        uses: metamask/github-tools/.github/actions/setup-environment@caching
 
       - name: Check attributions changes
         run: yarn attributions:check

.github/workflows/check-pr-labels.yml

@@ -17,11 +17,8 @@ jobs:
       pull-requests: read
 
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
       - name: Setup environment
-        uses: metamask/github-tools/.github/actions/setup-environment@main
+        uses: metamask/github-tools/.github/actions/setup-environment@caching
 
       - name: Check PR has required labels
         env:

.github/workflows/check-template-and-add-labels.yml

@@ -10,11 +10,8 @@ jobs:
   check-template-and-add-labels:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
       - name: Setup environment
-        uses: metamask/github-tools/.github/actions/setup-environment@main
+        uses: metamask/github-tools/.github/actions/setup-environment@caching
 
       - name: Check template and add labels
         id: check-template-and-add-labels

.github/workflows/close-bug-report.yml

@@ -12,11 +12,8 @@ jobs:
     runs-on: ubuntu-latest
     if: github.event.pull_request.merged == true && startsWith(github.event.pull_request.head.ref, 'Version-v')
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
       - name: Setup environment
-        uses: metamask/github-tools/.github/actions/setup-environment@main
+        uses: metamask/github-tools/.github/actions/setup-environment@caching
 
       - name: Close release bug report issue
         env:

.github/workflows/fitness-functions.yml

@@ -11,14 +11,11 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
+      - name: Setup environment
+        uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
           fetch-depth: 0 # This is needed to checkout all branches
 
-      - name: Setup environment
-        uses: metamask/github-tools/.github/actions/setup-environment@main
-
       - name: Run fitness functions
         env:
           BASE_REF: ${{ github.event.pull_request.base.ref }}

.github/workflows/main.yml

@@ -15,62 +15,52 @@ on:
   merge_group:
 
 jobs:
+  prep-deps:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Setup environment
+        uses: metamask/github-tools/.github/actions/setup-environment@caching
+        with:
+          should-cache-restore: 'false'
+          should-cache-save: ${{ vars.USE_CACHING }}
+          # -- If you're a repo admin, you can change vars.USE_CACHING at:
+          #    https://github.com/MetaMask/metamask-extension/settings/variables/actions
+          # -- If you're just a contributor, you can change vars.USE_CACHING by following this documentation:
+          #    https://docs.github.com/en/rest/actions/variables?apiVersion=2022-11-28#update-a-repository-variable
+
   lint-workflows:
     name: Lint workflows
-    uses: metamask/github-tools/.github/workflows/lint-workflows.yml@benchmarks
-
-  test-lint-shellcheck:
-    name: Test lint shellcheck
-    uses: ./.github/workflows/test-lint-shellcheck.yml
+    uses: metamask/github-tools/.github/workflows/lint-workflows.yml@caching
 
   test-lint:
-    name: Test lint
+    needs: prep-deps
     uses: ./.github/workflows/test-lint.yml
 
-  test-lint-changelog:
-    name: Test lint changelog
-    uses: ./.github/workflows/test-lint-changelog.yml
-
-  test-lint-lockfile:
-    name: Test lint lockfile
-    uses: ./.github/workflows/test-lint-lockfile.yml
-
-  test-deps-audit:
-    name: Test deps audit
-    uses: ./.github/workflows/test-deps-audit.yml
-
-  test-yarn-dedupe:
-    name: Test yarn dedupe
-    uses: ./.github/workflows/test-yarn-dedupe.yml
-
-  test-deps-depcheck:
-    name: Test deps depcheck
-    uses: ./.github/workflows/test-deps-depcheck.yml
+  test-short-suite:
+    needs: prep-deps
+    uses: ./.github/workflows/test-short-suite.yml
 
   test-storybook:
     name: Test storybook
+    needs: prep-deps
     uses: ./.github/workflows/test-storybook.yml
 
-  validate-lavamoat-allow-scripts:
-    name: Validate lavamoat allow scripts
-    uses: ./.github/workflows/validate-lavamoat-allow-scripts.yml
-
   validate-lavamoat-policy-build:
-    name: Validate lavamoat policy build
+    needs: prep-deps
     uses: ./.github/workflows/validate-lavamoat-policy-build.yml
 
   validate-lavamoat-policy-webapp:
-    name: Validate lavamoat policy webapp
+    needs: prep-deps
     uses: ./.github/workflows/validate-lavamoat-policy-webapp.yml
 
   prep-build-test-webpack:
+    needs: prep-deps
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
       - name: Setup environment
-        uses: metamask/github-tools/.github/actions/setup-environment@main
+        uses: metamask/github-tools/.github/actions/setup-environment@caching
+        with:
+          should-cache-restore: ${{ vars.USE_CACHING }}
 
       - run: yarn webpack --test --no-lavamoat --no-cache --browser=chrome --lockdown --sentry --snow --env production
         env:
@@ -85,6 +75,7 @@ jobs:
 
   run-tests:
     name: Run tests
+    needs: prep-deps
     uses: ./.github/workflows/run-tests.yml
 
   run-pageload-benchmark:
@@ -150,21 +141,14 @@ jobs:
     runs-on: ubuntu-latest
     needs:
       - lint-workflows
-      - test-lint-shellcheck
       - test-lint
-      - test-lint-changelog
-      - test-lint-lockfile
-      - test-yarn-dedupe
-      - test-deps-depcheck
-      - test-storybook
-      - validate-lavamoat-allow-scripts
+      - test-short-suite
       - validate-lavamoat-policy-build
       - validate-lavamoat-policy-webapp
       - run-tests
       # - run-pageload-benchmark # Will enable this as a required job in a later PR
       # - run-user-actions-benchmark # Will enable this as a required job in a later PR
       - wait-for-circleci-workflow-status
-      - build-storybook
       - build-beta
     outputs:
       PASSED: ${{ steps.set-output.outputs.PASSED }}

.github/workflows/publish-prerelease.yml

@@ -11,13 +11,11 @@ jobs:
     name: Publish prerelease
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
+      - name: Setup environment
+        uses: metamask/github-tools/.github/actions/setup-environment@caching
         with:
           fetch-depth: 0 # This is needed to get merge base to calculate bundle size diff
-
-      - name: Setup environment
-        uses: metamask/github-tools/.github/actions/setup-environment@main
+          no-cache-for-release: 'true' # Turn off yarn cache as well
 
       - name: Get merge base commit hash
         id: get-merge-base

.github/workflows/run-tests.yml

@@ -18,11 +18,10 @@ jobs:
       matrix:
         shard: [1, 2, 3, 4, 5, 6]
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
       - name: Setup environment
-        uses: metamask/github-tools/.github/actions/setup-environment@main
+        uses: metamask/github-tools/.github/actions/setup-environment@caching
+        with:
+          should-cache-restore: ${{ vars.USE_CACHING }}
 
       - name: test:unit:coverage
         run: yarn test:unit:coverage --shard=${{ matrix.shard }}/${{ strategy.job-total }}
@@ -39,11 +38,10 @@ jobs:
     name: Webpack tests
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
       - name: Setup environment
-        uses: metamask/github-tools/.github/actions/setup-environment@main
+        uses: metamask/github-tools/.github/actions/setup-environment@caching
+        with:
+          should-cache-restore: ${{ vars.USE_CACHING }}
 
       - name: test:unit:webpack:coverage
         run: yarn test:unit:webpack:coverage
@@ -60,11 +58,10 @@ jobs:
     name: Integration tests
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
       - name: Setup environment
-        uses: metamask/github-tools/.github/actions/setup-environment@main
+        uses: metamask/github-tools/.github/actions/setup-environment@caching
+        with:
+          should-cache-restore: ${{ vars.USE_CACHING }}
 
       - name: test:integration:coverage
         run: yarn test:integration:coverage
@@ -88,11 +85,10 @@ jobs:
       current-coverage: ${{ steps.get-current-coverage.outputs.CURRENT_COVERAGE }}
       stored-coverage: ${{ steps.get-stored-coverage.outputs.STORED_COVERAGE }}
     steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
       - name: Setup environment
-        uses: metamask/github-tools/.github/actions/setup-environment@main
+        uses: metamask/github-tools/.github/actions/setup-environment@caching
+        with:
+          should-cache-restore: ${{ vars.USE_CACHING }}
 
       - name: Download artifacts
         uses: actions/download-artifact@v4