Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Add support for ENS on Sepolia #22797

Closed
9 tasks
benjisclowder opened this issue Feb 2, 2024 · 3 comments · Fixed by #26242
Closed
9 tasks

[ENHANCEMENT] Add support for ENS on Sepolia #22797

benjisclowder opened this issue Feb 2, 2024 · 3 comments · Fixed by #26242

Comments

@benjisclowder
Copy link
Contributor

What is this about?

Currently ENS is not supported on Sepolia and with further deprecation of Georli, ENS testing will be blocked due to Sepolia not supporting this.

Message that comes up when typing a valid ENS address at the moment: No address has been set for this name.

Scenario

  • GIVEN a user is trying to send a transaction to a ENS address
  • WHEN a user is typing the ENS address
  • AND a user wants to proceed with the transaction
  • THEN ENS address should be accepted

Design

No response

Technical Details

ENS support needs to be added on Sepolia due to deprecation of Goerli and lack of means to test the ENS feature in these conditions.

Threat Modeling Framework

This will help us further test the feature and prevent issues from being released in prod.

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@Chomtana
Copy link

Chomtana commented Feb 8, 2024

Hi, @benjisclowder I have added ENS support for Sepolia to the Metamask. The original author of ethereum-ens-network-map has not maintained their package anymore. We can help continue maintaining this package if you like.

#22869

@jtippett
Copy link

jtippett commented Sep 9, 2024

Any action on this one? Seems very straightforward. Upon review of the ethereum-ens-network-map lib (as proposed in the PR) - it's so simple it could even just be imported somewhere and avoid the dependency. https://github.com/Opti-domains/ethereum-ens-network-map/blob/master/index.js

@mirceanis
Copy link
Contributor

will be resolved by #26242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants