Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ENS on Sepolia #22869

Closed
wants to merge 1 commit into from

Conversation

Chomtana
Copy link

@Chomtana Chomtana commented Feb 8, 2024

Description

This pull request introduces support for ENS exclusively on Sepolia, without including any other domains. We achieved this by switching the ethereum-ens-network-map package to our own fork, npm:@optidomains/[email protected].

We have opted for an exact package version to ensure safety, preventing the package from being secretly updated without the Metamask team's approval.

The ethereum-ens-network-map package has been left unmaintained for years. By merging this pull request, we commit to maintaining the package moving forward, including but not limited to supporting any ENS domain name in the future, such as those on the Holesky testnet.

Related issues

Fixes: #22797

Manual testing steps

  1. Open the extension. The Welcome Back screen is displayed.
  2. Proceed to unlock the wallet with a password (minimum of 8 characters). The Ether balance and wallet address are displayed on the overview, with the selected network being Ethereum Mainnet.
  3. Switch networks to a test network, such as Sepolia. The Sepolia balance and wallet address are displayed on the overview, with the selected network being Sepolia.
  4. Proceed to the Send flow.
  5. Enter an ENS address, for example, chomtana.eth. A matching result appears in the recipient list, showing both the ENS address and the hexadecimal address.
  6. Select the matching recipient. The send screen displays the ENS and hexadecimal addresses in the recipient field.
  7. Enter an amount, for example, 0.01.
  8. Proceed to the confirmation screen. The recipient's ENS address is displayed.
  9. Confirm the transaction. The transaction is then listed in the activity list.

For e2e testing, I don't think additional e2e tests are needed.

The current one in ens.spec.js with mock infura should be sufficient.

Screenshots/Recordings

Before

image
2024-02-08.13-48-44-03.mp4

After

image image
2024-02-08.14-21-57-68.mp4

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Chomtana Chomtana requested a review from a team as a code owner February 8, 2024 07:25
Copy link
Contributor

github-actions bot commented Feb 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Chomtana
Copy link
Author

Chomtana commented Feb 8, 2024

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

github-actions bot commented Apr 8, 2024

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Apr 8, 2024
Copy link
Contributor

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

@github-actions github-actions bot closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor stale issues and PRs marked as stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Add support for ENS on Sepolia
2 participants