Add support for ENS on Sepolia #22869
Closed
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces support for ENS exclusively on Sepolia, without including any other domains. We achieved this by switching the
ethereum-ens-network-map
package to our own fork,npm:@optidomains/[email protected]
.We have opted for an exact package version to ensure safety, preventing the package from being secretly updated without the Metamask team's approval.
The
ethereum-ens-network-map
package has been left unmaintained for years. By merging this pull request, we commit to maintaining the package moving forward, including but not limited to supporting any ENS domain name in the future, such as those on the Holesky testnet.Related issues
Fixes: #22797
Manual testing steps
For e2e testing, I don't think additional e2e tests are needed.
The current one in ens.spec.js with mock infura should be sufficient.
Screenshots/Recordings
Before
2024-02-08.13-48-44-03.mp4
After
2024-02-08.14-21-57-68.mp4
Pre-merge author checklist
Pre-merge reviewer checklist