-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signature Redesign - add any required metrics to re-designed signature request pages #23555
Comments
New metrics:
|
Hey team! Please add your planning poker estimate with Zenhub @digiwand @jpuri @pedronfigueiredo @segun |
Hey @bschorchit : can you plz spec
|
done @jpuri ! |
I began working on this ticket. I discovered there was a flaw in an existing metric I attempted to fix 2 months ago. The transaction event with key value 'external_link_clicked': 'security_alert_support_link', is only applied to transactions that are not signatures. We wanted to apply this to both transactions and signatures. This is relevant because I attempted to use the same method, ticket created to handle issue where external_link_clicked is not being called for signatures |
re: redesigned_confirmation to the ui_customizations
^ nevermind. As discussed in earlier's standup, "Cancel" and "Confirm" events will be deprecated. Instead, following the preference setting that will be added to enable the redesign confirmations, we will
|
re:
as discussed in earlier's standup, we'll not append the property to existing signature events. Instead, we will create a new event to be fired when the account modal is opened we will use
|
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Adds "Account Details Opened" event when Account Info Icon in Confirmation Redesign is clicked Internal Thread https://consensys.slack.com/archives/C03ETQA9EPK/p1710437328642929 Event Description https://www.notion.so/Account-Details-Opened-3deec398d4784bcea00b012cdf1cde03?pvs=4 [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24095?quickstart=1) ## **Related issues** Fixes: #23555 ## **Manual testing steps** 1. set ` ENABLE_CONFIRMATION_REDESIGN=true` in .metamaskrc 2. Turn on MetaMetrics in settings 3. Use test-dapp to test feature in a signature confirmation ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Missing release label release-11.17.0 on issue. Adding release label release-11.17.0 on issue, as issue is linked to PR #24182 which has this release label. |
Signature rest pages did not had any metrics events to be ported to new designed pages. (Typed sign V3, V4 pages has a legacy events that was re-redundant).
We need to check with @bschorchit and any new metrics events required for redesigned pages.
The text was updated successfully, but these errors were encountered: