Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Signature Redesign "Account Details Opened" event #24095

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Apr 17, 2024

Description

Adds "Account Details Opened" event when Account Info Icon in Confirmation Redesign is clicked

Internal Thread https://consensys.slack.com/archives/C03ETQA9EPK/p1710437328642929
Event Description https://www.notion.so/Account-Details-Opened-3deec398d4784bcea00b012cdf1cde03?pvs=4

Open in GitHub Codespaces

Related issues

Fixes: #23555

Manual testing steps

  1. set ENABLE_CONFIRMATION_REDESIGN=true in .metamaskrc
  2. Turn on MetaMetrics in settings
  3. Use test-dapp to test feature in a signature confirmation

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested review from a team as code owners April 17, 2024 23:18
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@digiwand digiwand added the team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead label Apr 18, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [75d0d57]
Page Load Metrics (805 ± 536 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint633601267436
domContentLoaded1097282311
load5025478051116536
domInteractive1097282311
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.18 KiB (0.02%)
  • common: 46 Bytes (0.00%)

@digiwand digiwand merged commit 15ad0b2 into develop Apr 19, 2024
75 of 79 checks passed
@digiwand digiwand deleted the feat-add-confirm-redesign-account-modal-open-metric branch April 19, 2024 16:40
@github-actions github-actions bot locked and limited conversation to collaborators Apr 19, 2024
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signature Redesign - add any required metrics to re-designed signature request pages
4 participants