Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removes portfolio button & fixes code fence of receive modal #27286

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

zone-live
Copy link
Contributor

Description

In MMI we don't want to show the new Portfolio button, therefore we are code fencing it.
Fixes the "receive" modal for MMI build, because of a misplaced code fence.

Screenshot 2024-09-19 at 16 27 38

Screenshot 2024-09-19 at 16 27 22

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live requested a review from a team as a code owner September 19, 2024 15:29
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-mmi PRs from the MMI team label Sep 19, 2024
NidhiKJha
NidhiKJha previously approved these changes Sep 19, 2024
Copy link

sonarcloud bot commented Sep 20, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [5718e63]
Page Load Metrics (1844 ± 155 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint152628041837327157
domContentLoaded151927901814318153
load154228021844322155
domInteractive219337178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants