Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump message signing snap to support portfolio automatic connections #27306

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Sep 20, 2024

Description

Bumps @metamask/message-signing-snap to 0.4.0 to allow portfolio to support automatic connections.

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/NOTIFY-1136

Manual testing steps

This does not effect anything within the wallet.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications Notifications team label Sep 20, 2024
@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner September 20, 2024 14:39
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

socket-security bot commented Sep 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 232 kB metamaskbot
npm/[email protected] None 0 667 kB colinmcd94

🚮 Removed packages: npm/@metamask/[email protected], npm/[email protected]

View full report↗︎

mathieuartu
mathieuartu previously approved these changes Sep 20, 2024
dovydas55
dovydas55 previously approved these changes Sep 20, 2024
Copy link

sonarcloud bot commented Sep 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants