fix: bump message signing snap to support portfolio automatic connections #27306
+19
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… NOTIFY-1136/bump-message-signing-snap
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected], npm/[email protected] |
mathieuartu
previously approved these changes
Sep 20, 2024
dovydas55
previously approved these changes
Sep 20, 2024
Prithpal-Sooriya
dismissed stale reviews from dovydas55 and mathieuartu
via
cf2576e
mathieuartu
previously approved these changes
Sep 20, 2024
dovydas55
previously approved these changes
Sep 20, 2024
|
This cannot be merged as there are e2e tests that are failing. Investigating. |
… NOTIFY-1136/bump-message-signing-snap
7 tasks
… NOTIFY-1136/bump-message-signing-snap
|
Converted to draft, as there is a e2e test that needs fixing, but I haven't got time to fix this anytime soon. |
… NOTIFY-1136/bump-message-signing-snap
…taMask/metamask-extension into NOTIFY-1136/bump-message-signing-snap
|
4 tasks
FrederikBolding
added a commit
to MetaMask/core
that referenced
this pull request
Oct 16, 2024
## Explanation This PR fixes a rare problem that would occur when deleting a network after a proxy in `SelectedNetworkController` has been garbage collected. When this happens, `getProviderAndBlockTracker` will fail to find the old network client ID and thus updating the network client ID for the domain will fail. This could be reproduced in an E2E test that would only fail on this branch: MetaMask/metamask-extension#27306 which enables `initialConnections` for a preinstalled Snap. `initialConnections` adds a permission for an origin to connect to a Snap which causes the `SelectedNetworkController` to register the domain. My theory is that since the user has not accessed the origin in question yet, the proxy may not be used and may be garbage collected. If a network is deleted following that, an error occurs. ## Changelog <!-- If you're making any consumer-facing changes, list those changes here as if you were updating a changelog, using the template below as a guide. (CATEGORY is one of BREAKING, ADDED, CHANGED, DEPRECATED, REMOVED, or FIXED. For security-related issues, follow the Security Advisory process.) Please take care to name the exact pieces of the API you've added or changed (e.g. types, interfaces, functions, or methods). If there are any breaking changes, make sure to offer a solution for consumers to follow once they upgrade to the changes. Finally, if you're only making changes to development scripts or tests, you may replace the template below with "None". --> ### `@metamask/selected-network-controller` - **Fixed**: Ensure that network client ID is updated before using it ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
…taMask/metamask-extension into NOTIFY-1136/bump-message-signing-snap
matteoscurati
dismissed stale reviews from dovydas55 and mathieuartu
via
b715844
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps
@metamask/message-signing-snapto0.4.0to allow portfolio to support automatic connections.Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/NOTIFY-1136
Manual testing steps
This does not effect anything within the wallet.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist