-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: en_GB
locale not covered by linter
#29965
Labels
Comments
Gudahtt
added
area-CI
team-extension-platform
Sev3-low
Low severity; minimal to no impact upon users
labels
Jan 29, 2025
Gudahtt
added a commit
that referenced
this issue
Jan 29, 2025
The `verify-locales` linter script now lints `en_GB`. Previously it was ignored, so it had accumulated errors. All errors in this locale file have been corrected as well. This locale file is not actually used in the app, it's just present to enable us to set a different UK-specific store description. Closes #29965
7 tasks
Gudahtt
added a commit
that referenced
this issue
Jan 29, 2025
The `verify-locales` linter script now lints `en_GB`. Previously it was ignored, so it had accumulated errors. All errors in this locale file have been corrected as well. This locale file is not actually used in the app, it's just present to enable us to set a different UK-specific store description. Closes #29965
Gudahtt
added a commit
that referenced
this issue
Jan 29, 2025
The `verify-locales` linter script now lints `en_GB`. Previously it was ignored, so it had accumulated errors. All errors in this locale file have been corrected as well. This locale file is not actually used in the app, it's just present to enable us to set a different UK-specific store description. Closes #29965
Gudahtt
added a commit
that referenced
this issue
Jan 29, 2025
The `verify-locales` linter script now lints `en_GB`. Previously it was ignored, so it had accumulated errors. All errors in this locale file have been corrected as well. This locale file is not actually used in the app, it's just present to enable us to set a different UK-specific store description. Closes #29965
Gudahtt
added a commit
that referenced
this issue
Jan 29, 2025
The `verify-locales` linter script now lints `en_GB`. Previously it was ignored, so it had accumulated errors. All errors in this locale file have been corrected as well. This locale file is not actually used in the app, it's just present to enable us to set a different UK-specific store description. Closes #29965
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Describe the bug
The
en_GB
is not covered by ourverify-locales
linter script, so it has become out-of-sync withen
.Expected behavior
The
en_GB
should be linted to ensure we aren't missing keys, or keeping around obsolete keysScreenshots/Recordings
No response
Steps to reproduce
en_GB
yarn verify-locales
Error messages or log output
Detection stage
On main branch
Version
main
Build type
None
Browser
Other (please elaborate in the "Additional Context" section)
Operating system
Other (please elaborate in the "Additional Context" section)
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: