chore: remove MMI UI code #29884

shane-t · 2025-01-23T20:07:46Z

Description

As part of the MMI deprecation and code removal, it's necessary to remove the fenced UI code before the background code, since the UI code is lower in the dependency chain.

This PR removes any code that's inside a @build-mmi code fence. In order to satisfy various requirements this also means removing unused imports, which the PR also deletes.

The PR also removes tests (which have never been code fenced) because in many cases they are caused by fenced code.

In addition, any non-fenced code which is known to be MMI specific is removed.

It does not remove inverse MMI code fences, i.e. fences which are there to stop things running in MMI and are now redundant. This is for the sake of keeping the PR a bit smaller. Those will be removed in the next PR.

Related issues

Fixes: #29782

Manual testing steps

Not applicable, as no new feature is added. However, many/most UI features are touched.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2025-01-24T01:12:37Z

Builds ready [9d8b59d]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (2066 ± 269 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1406	3215	2073	565	272
		domContentLoaded	1398	3055	2032	536	257
		load	1406	3099	2066	559	269
		domInteractive	24	164	65	49	23
		backgroundConnect	11	131	47	35	17
		firstReactRender	16	95	43	24	11
		getState	5	78	22	22	11
		initialActions	0	0	0	0	0
		loadScripts	1003	2361	1531	456	219
		setupStore	6	54	24	18	9
		uiStartup	1619	3646	2388	640	307

Bundle size diffs [🚀 Bundle size reduced!]

background: -120 Bytes (-0.00%)
ui: -9.18 KiB (-0.12%)
common: -341 Bytes (-0.00%)

shane-t · 2025-01-24T01:59:43Z

ui/components/component-library/icon/icon.types.ts

@@ -61,6 +61,7 @@ export enum IconName {
  Connect = 'connect',
  CopySuccess = 'copy-success',
  Copy = 'copy',
+  Custody = 'custody',


The snaps SDK exports a type that contains this, so we can't remove this without causing typescript errors

There is also an instance of this being used in a test that has not been removed

metamaskbot · 2025-01-24T02:12:46Z

Builds ready [749bfb1]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1869 ± 86 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	241	2407	1792	398	191
		domContentLoaded	1660	2382	1831	184	88
		load	1682	2399	1869	180	86
		domInteractive	26	102	42	22	11
		backgroundConnect	16	139	50	30	15
		firstReactRender	16	95	43	28	13
		getState	7	75	27	22	10
		initialActions	0	1	0	0	0
		loadScripts	1171	1874	1345	175	84
		setupStore	7	79	19	20	10
		uiStartup	1961	2685	2177	220	106

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: -9.18 KiB (-0.12%)
common: -5.63 KiB (-0.06%)

metamaskbot · 2025-01-24T19:54:46Z

Builds ready [c407b74]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1688 ± 91 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	273	2154	1614	359	172
		domContentLoaded	1435	2129	1659	173	83
		load	1479	2199	1688	189	91
		domInteractive	24	108	38	23	11
		backgroundConnect	8	95	30	24	11
		firstReactRender	16	94	45	28	13
		getState	4	90	20	24	12
		initialActions	0	1	0	0	0
		loadScripts	1015	1648	1190	147	71
		setupStore	7	81	18	21	10
		uiStartup	1671	2651	1972	298	143

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: -9.15 KiB (-0.11%)
common: -5.63 KiB (-0.06%)

metamaskbot · 2025-01-24T22:12:03Z

Builds ready [f21a6ad]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1723 ± 72 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1498	2079	1724	154	74
		domContentLoaded	1488	2008	1692	140	67
		load	1501	2031	1723	150	72
		domInteractive	21	98	38	18	9
		backgroundConnect	8	75	30	21	10
		firstReactRender	16	78	30	20	10
		getState	5	67	21	20	10
		initialActions	0	0	0	0	0
		loadScripts	1024	1525	1228	135	65
		setupStore	8	65	21	19	9
		uiStartup	1688	2373	1967	168	81

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: -9.15 KiB (-0.11%)
common: -5.63 KiB (-0.06%)

metamaskbot · 2025-01-28T03:37:34Z

Builds ready [3358806]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

Page Load Metrics (1904 ± 56 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	234	2148	1744	496	238
		domContentLoaded	1712	2064	1879	116	56
		load	1724	2093	1904	116	56
		domInteractive	25	168	53	32	15
		backgroundConnect	10	72	25	18	9
		firstReactRender	16	99	42	29	14
		getState	5	63	28	22	11
		initialActions	0	1	0	0	0
		loadScripts	1189	1609	1388	111	53
		setupStore	8	89	26	26	13
		uiStartup	1974	2779	2213	217	104

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: -9.15 KiB (-0.11%)
common: -5.63 KiB (-0.06%)

georgewrmarshall

Left one comment. Also there are some unused CSS classes that still need to be removed. When searching for institutional in the ui/ folder it shouldn't block this PR though

georgewrmarshall · 2025-01-28T19:27:50Z

ui/components/component-library/icon/icon.types.ts

@@ -61,6 +61,7 @@ export enum IconName {
  Connect = 'connect',
  CopySuccess = 'copy-success',
  Copy = 'copy',
+  Custody = 'custody',


There is also an instance of this being used in a test that has not been removed

NidhiKJha

LGTM! Verified the componenents in multichain directory

Gudahtt · 2025-01-28T19:44:01Z

app/_locales/en/messages.json

Looks like we need to make the same deletions in en_GB

Our linter script must not consider en_GB. Consider this as non-blocking, we can fix that separately. There may be other discrepencies with that locale as well, since the linter misses it.

Tracked here: #29965

sleepytanya

Reviewed Confirmations directories.

ui/components/ui/metafox-logo/horizontal-logo.js

ui/pages/confirmations/components/signature-request-original/signature-request-original.test.js

Gudahtt

LGTM! As George highlighted, there are a couple more custody/institutional references in UI tests/mock data/stypes, but we can remove those separately

metamaskbot added the team-mmi PRs from the MMI team label Jan 23, 2025

shane-t force-pushed the 29782-remove-mmi-ui-code branch 6 times, most recently from 9d8b59d to b470fab Compare January 24, 2025 01:10

shane-t mentioned this pull request Jan 23, 2025

Remove MetaMask Institutional code #29782

Closed

9 tasks

shane-t added 4 commits January 24, 2025 01:36

chore: remove MMI fenced UI code

8a94a4a

chore: remove unused locales

c6756ca

chore: remove MMI integration tests

91fad5a

chore: fix formatting issues with files that have removed tests

749bfb1

shane-t force-pushed the 29782-remove-mmi-ui-code branch from d7d5042 to 749bfb1 Compare January 24, 2025 01:37

shane-t changed the title ~~chore: remove MMI fenced UI code~~ Remove MMI UI code Jan 24, 2025

shane-t marked this pull request as ready for review January 24, 2025 01:45

shane-t requested review from a team as code owners January 24, 2025 01:45

shane-t changed the title ~~Remove MMI UI code~~ chore: remove MMI UI code Jan 24, 2025

shane-t commented Jan 24, 2025

View reviewed changes

Merge branch 'main' into 29782-remove-mmi-ui-code

c407b74

Merge branch 'main' into 29782-remove-mmi-ui-code

f21a6ad

Merge branch 'main' into 29782-remove-mmi-ui-code

3358806

georgewrmarshall approved these changes Jan 28, 2025

View reviewed changes

georgewrmarshall reviewed Jan 28, 2025

View reviewed changes

NidhiKJha approved these changes Jan 28, 2025

View reviewed changes

Gudahtt reviewed Jan 28, 2025

View reviewed changes

sleepytanya approved these changes Jan 28, 2025

View reviewed changes

Gudahtt reviewed Jan 29, 2025

View reviewed changes

ui/components/ui/metafox-logo/horizontal-logo.js Show resolved Hide resolved

Gudahtt reviewed Jan 29, 2025

View reviewed changes

ui/pages/confirmations/components/signature-request-original/signature-request-original.test.js Show resolved Hide resolved

Gudahtt approved these changes Jan 29, 2025

View reviewed changes

Gudahtt added this pull request to the merge queue Jan 29, 2025

Merged via the queue into main with commit 08365f0 Jan 29, 2025
70 checks passed

Gudahtt deleted the 29782-remove-mmi-ui-code branch January 29, 2025 14:46

github-actions bot locked and limited conversation to collaborators Jan 29, 2025

metamaskbot added the release-12.12.0 Issue or pull request that will be included in release 12.12.0 label Jan 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove MMI UI code #29884

chore: remove MMI UI code #29884

shane-t commented Jan 23, 2025 •

edited

Loading

metamaskbot commented Jan 24, 2025

shane-t Jan 24, 2025

georgewrmarshall Jan 28, 2025

metamaskbot commented Jan 24, 2025

metamaskbot commented Jan 24, 2025

metamaskbot commented Jan 24, 2025

metamaskbot commented Jan 28, 2025

georgewrmarshall left a comment •

edited

Loading

georgewrmarshall Jan 28, 2025

NidhiKJha left a comment

Gudahtt Jan 28, 2025

Gudahtt Jan 28, 2025

Gudahtt Jan 29, 2025

sleepytanya left a comment

Gudahtt left a comment •

edited

Loading

chore: remove MMI UI code #29884

chore: remove MMI UI code #29884

Conversation

shane-t commented Jan 23, 2025 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

metamaskbot commented Jan 24, 2025

shane-t Jan 24, 2025

Choose a reason for hiding this comment

georgewrmarshall Jan 28, 2025

Choose a reason for hiding this comment

metamaskbot commented Jan 24, 2025

metamaskbot commented Jan 24, 2025

metamaskbot commented Jan 24, 2025

metamaskbot commented Jan 28, 2025

georgewrmarshall left a comment • edited Loading

Choose a reason for hiding this comment

georgewrmarshall Jan 28, 2025

Choose a reason for hiding this comment

NidhiKJha left a comment

Choose a reason for hiding this comment

Gudahtt Jan 28, 2025

Choose a reason for hiding this comment

Gudahtt Jan 28, 2025

Choose a reason for hiding this comment

Gudahtt Jan 29, 2025

Choose a reason for hiding this comment

sleepytanya left a comment

Choose a reason for hiding this comment

Gudahtt left a comment • edited Loading

Choose a reason for hiding this comment

shane-t commented Jan 23, 2025 •

edited

Loading

georgewrmarshall left a comment •

edited

Loading

Gudahtt left a comment •

edited

Loading