Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: en_GB locale not covered by linter #29965

Open
Gudahtt opened this issue Jan 29, 2025 · 0 comments · May be fixed by #29967
Open

[Bug]: en_GB locale not covered by linter #29965

Gudahtt opened this issue Jan 29, 2025 · 0 comments · May be fixed by #29967
Labels
area-CI Sev3-low Low severity; minimal to no impact upon users team-extension-platform type-bug

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Jan 29, 2025

Describe the bug

The en_GB is not covered by our verify-locales linter script, so it has become out-of-sync with en.

Expected behavior

The en_GB should be linted to ensure we aren't missing keys, or keeping around obsolete keys

Screenshots/Recordings

No response

Steps to reproduce

  • Add an extra key to en_GB
  • Run yarn verify-locales
    • There should be an error, but there is not

Error messages or log output

Detection stage

On main branch

Version

main

Build type

None

Browser

Other (please elaborate in the "Additional Context" section)

Operating system

Other (please elaborate in the "Additional Context" section)

Hardware wallet

No response

Additional context

No response

Severity

No response

@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Jan 29, 2025
@Gudahtt Gudahtt added area-CI team-extension-platform Sev3-low Low severity; minimal to no impact upon users labels Jan 29, 2025
Gudahtt added a commit that referenced this issue Jan 29, 2025
The `verify-locales` linter script now lints `en_GB`. Previously it was
ignored, so it had accumulated errors. All errors in this locale file
have been corrected as well.

This locale file is not actually used in the app, it's just present to
enable us to set a different UK-specific store description.

Closes #29965
@Gudahtt Gudahtt linked a pull request Jan 29, 2025 that will close this issue
7 tasks
Gudahtt added a commit that referenced this issue Jan 29, 2025
The `verify-locales` linter script now lints `en_GB`. Previously it was
ignored, so it had accumulated errors. All errors in this locale file
have been corrected as well.

This locale file is not actually used in the app, it's just present to
enable us to set a different UK-specific store description.

Closes #29965
Gudahtt added a commit that referenced this issue Jan 29, 2025
The `verify-locales` linter script now lints `en_GB`. Previously it was
ignored, so it had accumulated errors. All errors in this locale file
have been corrected as well.

This locale file is not actually used in the app, it's just present to
enable us to set a different UK-specific store description.

Closes #29965
Gudahtt added a commit that referenced this issue Jan 29, 2025
The `verify-locales` linter script now lints `en_GB`. Previously it was
ignored, so it had accumulated errors. All errors in this locale file
have been corrected as well.

This locale file is not actually used in the app, it's just present to
enable us to set a different UK-specific store description.

Closes #29965
Gudahtt added a commit that referenced this issue Jan 29, 2025
The `verify-locales` linter script now lints `en_GB`. Previously it was
ignored, so it had accumulated errors. All errors in this locale file
have been corrected as well.

This locale file is not actually used in the app, it's just present to
enable us to set a different UK-specific store description.

Closes #29965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CI Sev3-low Low severity; minimal to no impact upon users team-extension-platform type-bug
Projects
Status: To be fixed
Development

Successfully merging a pull request may close this issue.

1 participant