Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix #16852 - Update support link for BETA (#16853)" #25871

Closed
wants to merge 1 commit into from

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Jul 16, 2024

This reverts commit 7a1f75d.

Description

It was decided that we no longer want this specific Beta form.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@danjm danjm requested a review from a team as a code owner July 16, 2024 19:34
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Jul 16, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [eaee5d6]
Page Load Metrics (274 ± 296 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6963912811957
domContentLoaded9155343215
load432473274616296
domInteractive9155343215
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.76%. Comparing base (20f54db) to head (eaee5d6).
Report is 1293 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25871      +/-   ##
===========================================
- Coverage    69.76%   69.76%   -0.00%     
===========================================
  Files         1398     1398              
  Lines        49171    49170       -1     
  Branches     13574    13574              
===========================================
- Hits         34303    34302       -1     
  Misses       14868    14868              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darkwing darkwing added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Jul 16, 2024
@@ -42,7 +39,11 @@ const BetaHomeFooter = () => {
{t('needHelpSubmitTicket')}
</a>{' '}
|{' '}
<a href={SUPPORT_LINK} target="_blank" rel="noopener noreferrer">
<a
href="https://community.metamask.io/c/metamask-beta"
Copy link
Contributor

@seaona seaona Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the expected link here? I'm seeing Oops! That page doesn’t exist or is private

Screenshot from 2024-07-17 09-28-46

Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Sep 15, 2024
@Maliksb11

This comment was marked as spam.

@github-actions github-actions bot removed the stale issues and PRs marked as stale label Sep 15, 2024
@danjm danjm closed this Oct 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-extension-platform
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants