Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: always use snaps to resolve domains; include preinstalled ENS resolver snap #26242

Merged
merged 42 commits into from
Sep 18, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
19fbf60
feat: always use snaps to resolve domains; include preinstalled ENS r…
mirceanis Jul 29, 2024
6682719
chore(deps): add [email protected] dev dependency, expected by @account-ab…
mirceanis Aug 1, 2024
962b056
chore(ci): manually update lavamoat policy to match the one getting g…
mirceanis Aug 1, 2024
83e07e3
refactor: guard the use of ENS snap by BUILD_FLASK flag
mirceanis Aug 2, 2024
ea9817a
Merge remote-tracking branch 'refs/remotes/origin/develop' into feat/…
mirceanis Aug 12, 2024
546b2bc
chore: rebuild lavamoat policies
mirceanis Aug 12, 2024
b257696
Merge remote-tracking branch 'refs/remotes/origin/develop' into feat/…
mirceanis Aug 15, 2024
067b290
chore: rebuild lavamoat policies
mirceanis Aug 15, 2024
e4480f6
Merge remote-tracking branch 'refs/remotes/origin/develop' into feat/…
mirceanis Aug 20, 2024
bed62a1
refactor: strip flask checks for ENS snap
mirceanis Aug 20, 2024
76c9c2c
refactor: fix domain lookup condition and revert debounce interval
mirceanis Aug 20, 2024
827983e
chore(deps): remove unused ethereum-ens-network-map
mirceanis Aug 20, 2024
12a0b1c
test: update mocks for e2e ENS test
mirceanis Aug 20, 2024
3659d91
refactor: remove unused `domainType` prop
mirceanis Aug 21, 2024
aa5711d
Merge remote-tracking branch 'refs/remotes/origin/develop' into feat/…
mirceanis Aug 21, 2024
02be861
chore: rebuild lavamoat policy files
mirceanis Aug 21, 2024
545d42b
refactor: remove flask checks from `domain-input.component.js`
mirceanis Aug 21, 2024
dc08829
refactor: remove unused message
mirceanis Aug 21, 2024
6aa98d7
refactor: remove flask checks in send.js
mirceanis Aug 21, 2024
887cfd9
test: update test to reflect new error state
mirceanis Aug 21, 2024
4e7795c
fix: lookup name for any input that is not an address & validate poss…
mirceanis Aug 22, 2024
20e0eac
test: adapt e2e test for non-tld domain input
mirceanis Aug 22, 2024
02755b9
chore(deps): bump ens-resolver-snap to v0.1.2
mirceanis Aug 22, 2024
1034df2
refactor: update [english] placeholder message for send/to input box
mirceanis Aug 22, 2024
bc52608
refactor: rename message key for input placeholder to trigger re-tran…
mirceanis Aug 22, 2024
d033bf0
Merge remote-tracking branch 'refs/remotes/origin/develop' into feat/…
mirceanis Aug 23, 2024
4130779
Merge remote-tracking branch 'refs/remotes/origin/develop' into feat/…
mirceanis Sep 9, 2024
41b7f8d
refactor: remove unused reducers in domains.js
mirceanis Aug 20, 2024
c5d6a53
refactor: remove unused constants
mirceanis Aug 21, 2024
380b2ce
refactor: remove unused messages
mirceanis Aug 21, 2024
839234b
Merge remote-tracking branch 'refs/remotes/origin/develop' into feat/…
mirceanis Sep 10, 2024
fd1e725
Merge remote-tracking branch 'refs/remotes/origin/develop' into feat/…
mirceanis Sep 11, 2024
281ccbd
Merge remote-tracking branch 'refs/remotes/origin/develop' into feat/…
mirceanis Sep 11, 2024
35cf667
Merge remote-tracking branch 'refs/remotes/origin/develop' into feat/…
mirceanis Sep 12, 2024
7f38e75
Merge remote-tracking branch 'refs/remotes/origin/develop' into feat/…
mirceanis Sep 12, 2024
572c18a
Merge remote-tracking branch 'refs/remotes/origin/develop' into feat/…
mirceanis Sep 13, 2024
becba2a
style: fix linter error
mirceanis Sep 13, 2024
606b389
test: temporarily increase webdriver default timeout
mirceanis Sep 13, 2024
2fe6852
test: revert webdriver default timeout
mirceanis Sep 16, 2024
0afeb71
Merge remote-tracking branch 'refs/remotes/origin/develop' into feat/…
mirceanis Sep 16, 2024
7a75085
Merge remote-tracking branch 'refs/remotes/origin/develop' into feat/…
mirceanis Sep 18, 2024
2dcdfe4
chore: rebuild policies
mirceanis Sep 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .depcheckrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ ignores:
- '@sentry/cli' # invoked as `sentry-cli`
- 'chromedriver'
- 'depcheck' # ooo meta
- 'ethers' # ethers @5.7.0 expected by @account-abstraction/contracts, but conflicts with transitive [email protected]
- 'ganache-cli'
- 'geckodriver'
- 'jest'
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/metamask-controller.actions.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ describe('MetaMaskController', function () {
const noop = () => undefined;

beforeAll(async function () {
await ganacheServer.start();
await ganacheServer.start({ port: 32545 });
mirceanis marked this conversation as resolved.
Show resolved Hide resolved
});

beforeEach(function () {
Expand Down
2 changes: 2 additions & 0 deletions app/scripts/snaps/preinstalled-snaps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,14 @@ import type { PreinstalledSnap } from '@metamask/snaps-controllers';
import MessageSigningSnap from '@metamask/message-signing-snap/dist/preinstalled-snap.json';
///: BEGIN:ONLY_INCLUDE_IF(build-flask)
import BitcoinWalletSnap from '@metamask/bitcoin-wallet-snap/dist/preinstalled-snap.json';
import EnsResolverSnap from '@metamask/ens-resolver-snap/dist/preinstalled-snap.json';
///: END:ONLY_INCLUDE_IF

const PREINSTALLED_SNAPS: readonly PreinstalledSnap[] = Object.freeze([
MessageSigningSnap as PreinstalledSnap,
///: BEGIN:ONLY_INCLUDE_IF(build-flask)
BitcoinWalletSnap as PreinstalledSnap,
EnsResolverSnap as PreinstalledSnap,
///: END:ONLY_INCLUDE_IF
]);

Expand Down
Loading