chore: Add currency conversion telemetry #26876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [b01a18b]
Page Load Metrics (1670 ± 122 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26876 +/- ##
========================================
Coverage 70.01% 70.02%
========================================
Files 1445 1445
Lines 50197 50199 +2
Branches 14044 14044
========================================
+ Hits 35145 35147 +2
Misses 15052 15052 ☔ View full report in Codecov by Sentry. |
7 tasks
salimtb
previously approved these changes
Sep 4, 2024
Builds ready [9257eed]
Page Load Metrics (1808 ± 101 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [cebe1a7]
Page Load Metrics (1662 ± 75 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
sahar-fehri
reviewed
Sep 9, 2024
| category: MetaMetricsEventCategory.Settings, | ||
| event: MetaMetricsEventName.CurrentCurrencyChanged, | ||
| sensitiveProperties: { | ||
| current_currency_changed: newCurrency, |
There was a problem hiding this comment.
Wondering if there is a reason why we are using sensitiveProperties instead of properties here?
There was a problem hiding this comment.
Will change! Doesn't need to be sensitive. Also needs to be added to the user object anyway 👍
There was a problem hiding this comment.
Updated! I also added the trait to MetaMetricsUserTrait to get added to the user, which is what we want to track (not how many times the toggle was clicked)
…f github.com:MetaMask/metamask-extension into chore/mmassets-344_add-telemetry-currency-conversion
Builds ready [cdaef25]
Page Load Metrics (1688 ± 96 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [0add1f3]
Page Load Metrics (1777 ± 118 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gambinish
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
Sep 11, 2024
## **Description** Mobile companion to: MetaMask/metamask-extension#26876 In order to figure out which currencies we should support 24hr % change, we need to know which currencies are the most popular. This adds telemetry to the settings page to capture this. ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-344 ## **Manual testing steps** ## **Screenshots/Recordings** ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Nico MASSART <[email protected]>
Builds ready [87fa73a]
Page Load Metrics (1855 ± 146 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [0bbaec6]
Page Load Metrics (1684 ± 58 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
sahar-fehri
approved these changes
Sep 17, 2024
salimtb
approved these changes
Sep 17, 2024
|
gambinish
deleted the
chore/mmassets-344_add-telemetry-currency-conversion
branch
metamaskbot
added
the
release-12.6.0
Builds ready [a2a83b4]
Page Load Metrics (1879 ± 122 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to figure out which currencies we should support 24hr % change, we need to know which currencies are the most popular.
Adds currency change dropdown event to telemetry events.
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMASSETS-344
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist