chore: smart-transactions code domain #26948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [24fe0cf]
Page Load Metrics (1557 ± 68 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #26948 +/- ##
========================================
Coverage 70.01% 70.01%
========================================
Files 1445 1445
Lines 50194 50194
Branches 14041 14041
========================================
Hits 35139 35139
Misses 15055 15055 ☔ View full report in Codecov by Sentry. |
dan437
reviewed
Sep 13, 2024
| @@ -51,7 +51,7 @@ | |||
| @import 'recovery-phrase-reminder/index'; | |||
| @import 'step-progress-bar/index.scss'; | |||
| @import 'selected-account/index'; | |||
| @import 'smart-transactions/index'; | |||
| @import '../../pages/smart-transactions/components/index.scss'; | |||
There was a problem hiding this comment.
I don't see any other import from ../../pages in this component. Shouldn't we remove it from here and import it somewhere else?
Builds ready [ecb356e]
Page Load Metrics (1896 ± 131 ms)
Bundle size diffs
|
Builds ready [5565348]
Page Load Metrics (1939 ± 99 ms)
Bundle size diffs
|
|
Builds ready [d91bac2]
Page Load Metrics (1946 ± 108 ms)
Bundle size diffs
|
klejeune
approved these changes
Sep 18, 2024
NidhiKJha
approved these changes
Sep 18, 2024
metamaskbot
added
the
release-12.6.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR establishes the
ui/pages/smart-transactionscode domain, following the guidance in this proposal.The following files will be left in place.
ui/components/app/transaction-list-item/smart-transaction-list-item.component.jsui/pages/confirmations/confirmation/templates/smart-transaction-status-page.jsui/pages/swaps/smart-transaction-status/smart-transaction-status.jsSTX-related code in other files
The following files contain stx-related code, which may be extracted and moved into the smart-transactions code domain at a later time.
app/scripts/metamask-controller.jsnew SmartTransactionsController.*// Smart Transactionssection*ui/ducks/swaps/swaps.jsfetchSmartTransactionsLiveness,signAndSendSmartTransaction,setSmartTransactionsRefreshInterval, etc.ui/store/actions.tsfetchSmartTransactionsLivenessand other STX functionsui/pages/confirmations/confirm-transaction-base/confirm-transaction-base.container.jsui/pages/settings/advanced-tab/advanced-tab.component.jsui/pages/swaps/swaps.util.tsgetFeeForSmartTransactionui/pages/swaps/prepare-swap-page/review-quote.jsui/selectors/transactions.jsallowedSwapsSmartTransactionStatusesForActivityListRelated issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist