feat: aggregated balance feature #27097

sahar-fehri · 2024-09-12T09:54:28Z

Description

Removes the primary currency from Settings => General
Removes usage of useNativeCurrencyAsPrimaryCurrency
Adds a new toggle in settings: "show native tokens as main balance" which affects only the main coin overview.
When new setting is ON we will show to users the aggregated balance of their tokens in Fiat, else we show the balance in crypto for the native token.

This final PR is the combination of the following PRs:

1- Removal of useNativeCurrencyAsPrimaryCurrency setting and adding the new setting: #26870
2- Aggregated balance logic: #27108
3- Aggregated balance UI: #27161

Related issues

Fixes: https://github.com/orgs/MetaMask/projects/85/views/24?filterQuery=label%3A%22assets-aggregated%22
Figma: https://www.figma.com/design/aMYisczaJyEsYl1TYdcPUL/Portfolio-View?node-id=4098-126568&node-type=instance&focus-id=4186-130770&m=dev

#27280

Manual testing steps

Switch to Ethereum mainnet and go to home page
You should see the popover telling you about the new feature. You should not be able to see the popover again once closed.
You should be able to see the aggregated balance in fiat of you native token and imported ERC20 tokens
Go to settings; notice that there is no primary currency setting and you should see the new setting.
Turn on "show native token as main balance" and go back to home page; you should see your balance in crypto for the native token.
Switch to any testnet, exp (Sepolia), notice that you wont be able to see aggregated balance unless you turn on the setting "Show conversion on test networks" in settings => Advanced

Screenshots/Recordings

Before

After

Screen.Recording.2024-09-23.at.11.07.15.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding
Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

#26870) ## **Description** This PR is the initial PR for the aggregated balance feature. This PR: 1- Adds a new setting in Settings => General called; show native token as main balance. This setting is OFF by default. When the new setting is off; in home page` coin-overview.tsx`; we should see user balance in fiat, and when it is ON we should see user balance in crypto. In the main token list, we display native currency of the network as the first token; we should see balance in crypto as Primary and native as secondary if the new setting ON. When the toggle is OFF we should see fiat as primary and native as secondary. => This PR removes the display of secondary balance in the balance overview section in the home page. 2- Removes the fiat/native setting `useNativeCurrencyAsPrimaryCurrency` from the Settings => General page After removing this setting; we will be displaying by default crypto amounts first in the UI. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26870?quickstart=1) ## **Related issues** Fixes: MetaMask/MetaMask-planning#3193 (comment) MetaMask/MetaMask-planning#3184 (comment) ## **Manual testing steps** Test the new toggle in settings: 1. Create a new user or upgrade an old user 2. Go to Settings => General; you should see a new toggle "show native token as main balance" and it should be OFF by default 3. Go to home page; because the toggle is OFF, you should see your balance in fiat. 4. You should not see your secondary balance in the balance overview section. 5. Click on Tokens tab, you should see your balances for the native token of your network; should display fiat balance first then native balance. 6. Go to Settings=>General and turn the new setting ON 7. Go back to home page; you should see your native balance in crypto in the home section. 8. The native token in token list should display balance in crypto first then in fiat. Test the removal of the `useNativeCurrencyAsPrimaryCurrency` 1. New users or users who upgrade should not see any errors. 2. Go to settings=> general; you should not see the primary currency setting 3. In the send flow and in UI in general you should always see crypto amounts displayed first; => NOTE: The account list UI and the main tokenList for ERC20 displays fiat first always; this was the case also when we had `useNativeCurrencyAsPrimaryCurrency`, so the behavior remains untouched. ## **Screenshots/Recordings**  ## Setting page ### **Before** <img width="1797" alt="Screenshot 2024-09-04 at 17 11 41" src="https://github.com/user-attachments/assets/b9e1f87d-588b-4d75-8f68-21aa3f04a6fa"> ### **After** <img width="1130" alt="Screenshot 2024-09-04 at 18 27 57" src="https://github.com/user-attachments/assets/30c0429b-af20-4cff-89c4-71bbb3782c60"> ## Home page ### **Before** With crypto as primary currency: <img width="1123" alt="Screenshot 2024-09-04 at 17 15 51" src="https://github.com/user-attachments/assets/7b5f0f00-3921-42bc-b8ca-f7d7addcfde6"> With fiat as primary currency: <img width="1121" alt="Screenshot 2024-09-04 at 17 16 38" src="https://github.com/user-attachments/assets/231c7e56-276c-4733-a81b-49ab74f0ec56"> ### **After** With new setting show Native token as main balance ON <img width="1128" alt="Screenshot 2024-09-04 at 18 29 15" src="https://github.com/user-attachments/assets/7abcb661-82b8-4ef7-a720-0fd15ae6859e"> With new setting show Native token as main balance OFF <img width="1128" alt="Screenshot 2024-09-04 at 18 29 47" src="https://github.com/user-attachments/assets/872e439a-f8dc-4af3-845a-17cf2bb02d04"> ## Account list ### **Before** Is unchanged regardless of the primary currency setting <img width="1440" alt="Screenshot 2024-09-04 at 17 19 00" src="https://github.com/user-attachments/assets/1887d07b-8f1d-4418-b66d-575dd576a26e"> ### **After** <img width="389" alt="Screenshot 2024-09-04 at 18 30 09" src="https://github.com/user-attachments/assets/e76dbe1b-4ca8-4c09-b466-1ecf89f1017d"> ## Send page (For sending native currency) ### **Before** With crypto as primary currency <img width="412" alt="Screenshot 2024-09-04 at 17 21 39" src="https://github.com/user-attachments/assets/efce0db3-cb76-4451-be05-1d98f00988f7"> With fiat as primary currency <img width="420" alt="Screenshot 2024-09-04 at 17 28 26" src="https://github.com/user-attachments/assets/3ed45599-f423-4111-bd50-acc83f59d984"> ### **After** This UI does not affected by the new setting. <img width="434" alt="Screenshot 2024-09-04 at 18 31 41" src="https://github.com/user-attachments/assets/6919d6d3-f836-4718-a7f6-fdb346cd4e34"> ### Send confirmation page (For sending native currency) ### **Before** With crypto as primary currency <img width="427" alt="Screenshot 2024-09-04 at 17 38 01" src="https://github.com/user-attachments/assets/88b96c32-f116-4303-aefb-b8c0ea4b35e9"> With fiat as primary currency <img width="427" alt="Screenshot 2024-09-04 at 17 29 26" src="https://github.com/user-attachments/assets/6bc0b041-65a1-4a52-abd3-a3584c3d4c87"> ### **After** <img width="440" alt="Screenshot 2024-09-04 at 18 32 57" src="https://github.com/user-attachments/assets/fa72c4b9-97dc-437a-bac8-7347b4837d8c"> ## Send page (For sending ERC20 token) ### **Before** With crypto as primary currency <img width="425" alt="Screenshot 2024-09-04 at 17 43 43" src="https://github.com/user-attachments/assets/931a4da4-dc51-4d67-b337-f16d0d399421"> With fiat as primary currency <img width="424" alt="Screenshot 2024-09-04 at 17 44 26" src="https://github.com/user-attachments/assets/042b32d1-5b7e-4a4a-8c13-373fabc7daa4"> ### **After** <img width="427" alt="Screenshot 2024-09-04 at 18 33 34" src="https://github.com/user-attachments/assets/ab05f568-3696-4ecc-843c-aea54bbe4d52"> ### Send confirmation page (For sending ERC20 token) ### **Before** With crypto as primary currency <img width="438" alt="Screenshot 2024-09-04 at 17 45 25" src="https://github.com/user-attachments/assets/41aa5172-7261-4ce6-8b65-f2a929365f3a"> With fiat as primary currency <img width="431" alt="Screenshot 2024-09-04 at 17 58 24" src="https://github.com/user-attachments/assets/6ceb0d64-2031-4101-bd9c-b040391aa862"> ### **After** <img width="442" alt="Screenshot 2024-09-04 at 18 34 03" src="https://github.com/user-attachments/assets/1820dc03-9c71-43e5-932c-34c761ea159f"> All components in the codebase should display crypto by default. ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-09-12T09:54:47Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-09-12T15:40:07Z

Builds ready [c0e47ba]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1714 ± 133 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	184	2852	1566	527	253
		domContentLoaded	1493	2829	1695	277	133
		load	1527	2846	1714	277	133
		domInteractive	24	90	39	16	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 917 Bytes (0.03%)
ui: -3.78 KiB (-0.05%)
common: -181 Bytes (-0.00%)

codecov · 2024-09-12T15:40:32Z

Codecov Report

Attention: Patch coverage is 93.45794% with 7 lines in your changes missing coverage. Please review.

Project coverage is 70.05%. Comparing base (56c23fc) to head (ce79a77).
Report is 2 commits behind head on develop.

Files with missing lines	Patch %	Lines
...saction-base/confirm-transaction-base.component.js	0.00%	2 Missing ⚠️
...ages/confirmations/send/gas-display/gas-display.js	0.00%	2 Missing ⚠️
ui/store/actions.ts	0.00%	2 Missing ⚠️
...wallet-overview/aggregated-percentage-overview.tsx	97.14%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #27097      +/-   ##
===========================================
+ Coverage    70.01%   70.05%   +0.04%     
===========================================
  Files         1445     1447       +2     
  Lines        50201    50209       +8     
  Branches     14045    14034      -11     
===========================================
+ Hits         35147    35172      +25     
+ Misses       15054    15037      -17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

## **Description** This PR adds the logic for aggregated balance feature. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27108?quickstart=1) ## **Related issues** Fixes: MetaMask/MetaMask-planning#3185 (comment) ## **Manual testing steps** 1. Go to settings => general and make sure that by default the "Show native token as main balance" setting is off 2. Go to home page; you should be able to see your aggregated balance in fiat. 3. Go to settings => general and enable the toggle for "Show native token as main balance" 4. go back to main page; you should see you balance in crypto for the native currency ## **Screenshots/Recordings**  ### **Before**  ### **After** https://github.com/user-attachments/assets/f86cbf0d-c631-408d-8c78-efb007e86771  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2024-09-13T22:27:15Z

Builds ready [383715c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1669 ± 121 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	220	2409	1554	499	240
		domContentLoaded	1427	2351	1651	244	117
		load	1459	2411	1669	252	121
		domInteractive	22	76	33	14	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 917 Bytes (0.03%)
ui: 927 Bytes (0.01%)
common: -76 Bytes (-0.00%)

sonarcloud · 2024-09-17T14:21:19Z

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-09-17T15:15:59Z

Builds ready [ce79a77]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1837 ± 107 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	267	2307	1733	395	190
		domContentLoaded	1583	2297	1805	224	108
		load	1593	2318	1837	223	107
		domInteractive	15	130	44	29	14

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 917 Bytes (0.03%)
ui: 1.1 KiB (0.02%)
common: -76 Bytes (-0.00%)

## **Description** Aggregated balance UI feature; This PR fixed UI designs related to the aggregated balance feature; It also fixes the popover behavior; Users should be able to see the popover by default and should see it only once. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27161?quickstart=1) ## **Related issues** Fixes: Related: https://www.figma.com/design/aMYisczaJyEsYl1TYdcPUL/Portfolio-View?node-id=4098-126757&node-type=instance&focus-id=4186-130770&m=dev https://www.figma.com/design/aMYisczaJyEsYl1TYdcPUL/Portfolio-View?node-id=4496-20506&node-type=FRAME&m=dev ## **Manual testing steps** 1. After a new user is onboarded or upgraded, they should be able to see the aggregated balance popover. 2. Close the popover. Make sure you are not able to see the popover again even after turning on and off the new setting "show native token as main balance" ## **Screenshots/Recordings**  ### **Before**  ### **After** https://github.com/user-attachments/assets/4c01541e-0d77-46c3-8a21-98dc3114e11d ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2024-09-21T16:45:52Z

Builds ready [25d3df5]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1594 ± 63 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	278	2155	1537	322	155
		domContentLoaded	1458	1989	1563	116	56
		load	1482	2088	1594	132	63
		domInteractive	13	70	33	16	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.1 KiB (0.03%)
ui: 3.17 KiB (0.04%)
common: 160 Bytes (0.00%)

plasmacorral · 2024-09-28T05:46:36Z

Of everything listed above, the most concerning to me are 5, 13 and 14. I would recommend to stakeholders those be resolved or researched before shipping.

sahar-fehri · 2024-09-29T16:29:10Z

Of everything listed above, the most concerning to me are 5, 13 and 14. I would recommend to stakeholders those be resolved or researched before shipping.

Hi @plasmacorral ! Thanks again 🙏 13 issue should be fixed here 339c70d

Video:

upgrade2.mov

Were you also able to see 5 and 14 on chrome? I would expect that 5 is also present on develop; that url is related to the phishing controller which is not a flow that i have updated in this PR 🤔

14- I tested the toggle again and i can't seem to find exact steps to reproduce the repeated tap behavior you had 🤔

metamaskbot · 2024-09-30T20:21:21Z

Builds ready [203bf04]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1747 ± 73 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	494	2298	1685	319	153
		domContentLoaded	1544	2102	1727	131	63
		load	1552	2214	1747	151	73
		domInteractive	14	94	45	23	11

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.21 KiB (0.06%)
ui: 2.42 KiB (0.03%)
common: 148 Bytes (0.00%)

plasmacorral · 2024-10-01T14:06:29Z

Thanks for the video to show migration was resolved! Observations 5 and 14 were from Firefox, I did not see them in Chrome.

sonarcloud · 2024-10-02T07:33:21Z

Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-10-02T09:53:21Z

Builds ready [5b79963]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1836 ± 101 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1492	2500	1838	223	107
		domContentLoaded	1484	2494	1807	219	105
		load	1568	2499	1836	210	101
		domInteractive	23	148	51	31	15

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 2.21 KiB (0.06%)
ui: 2.42 KiB (0.03%)
common: 148 Bytes (0.00%)

github-actions bot added the team-assets label Sep 12, 2024

sahar-fehri changed the title ~~feat: add new setting and remove useNativeCurrencyAsPrimaryCurrency s…~~ feat: aggregated balance feature Sep 12, 2024

Merge branch 'develop' into feat/aggregated-balance-feature

c0e47ba

sahar-fehri added 2 commits September 13, 2024 14:37

fix: merge conflicts

79408f2

sahar-fehri added 4 commits September 16, 2024 09:09

Merge branch 'develop' into feat/aggregated-balance-feature

0cbb4ac

fix: fix merge conflicts add type for new preference

18992e2

fix: fix merge conflicts

9dc5b48

fix: fix lint

ce79a77

sahar-fehri added 7 commits September 20, 2024 14:28

fix: rm log and show popover on testnet if show conversion setting is on

6ff9669

fix: fix merge conflicts

e5e85e4

fix: e2e

a6b7571

fix: rm description for current locale

f19e550

fix: fix

a215630

fix: fix lint

25d3df5

sahar-fehri added 5 commits September 21, 2024 22:46

fix: fix

c5f5f23

fix: add e2e

90503ba

fix: add e2e

e46d196

fix: fix

9be7d16

fix: fix lint

bedb2ac

sahar-fehri marked this pull request as ready for review September 23, 2024 09:15

fix: fix shouldShowAggregatedBalancePopover for upgrades

339c70d

sahar-fehri dismissed gambinish’s stale review via 339c70d September 28, 2024 13:24

gambinish self-requested a review September 30, 2024 16:50

gambinish previously approved these changes Sep 30, 2024

View reviewed changes

sahar-fehri added 2 commits September 30, 2024 21:21

Merge branch 'develop' into feat/aggregated-balance-feature

2253bc3

fix: fix lint after merge

203bf04

sahar-fehri dismissed gambinish’s stale review via 203bf04 September 30, 2024 19:41

bergeron approved these changes Sep 30, 2024

View reviewed changes

gambinish approved these changes Sep 30, 2024

View reviewed changes

sahar-fehri requested review from albertolive and vinnyhoward September 30, 2024 21:55

vinnyhoward approved these changes Sep 30, 2024

View reviewed changes

plasmacorral removed DO-NOT-MERGE Pull requests that should not be merged QA'd but questions A QA run through has been done but you need clarification on minor issues you found labels Oct 1, 2024

albertolive approved these changes Oct 1, 2024

View reviewed changes

micaelae approved these changes Oct 1, 2024

View reviewed changes

Merge branch 'develop' into feat/aggregated-balance-feature

5b79963

matthewwalsh0 approved these changes Oct 2, 2024

View reviewed changes

sahar-fehri added this pull request to the merge queue Oct 2, 2024

Merged via the queue into develop with commit d26968f Oct 2, 2024
77 checks passed

sahar-fehri deleted the feat/aggregated-balance-feature branch October 2, 2024 13:42

github-actions bot locked and limited conversation to collaborators Oct 2, 2024

metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Oct 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: aggregated balance feature #27097

feat: aggregated balance feature #27097

sahar-fehri commented Sep 12, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024

metamaskbot commented Sep 12, 2024

codecov bot commented Sep 12, 2024 •

edited

Loading

metamaskbot commented Sep 13, 2024

sonarcloud bot commented Sep 17, 2024

metamaskbot commented Sep 17, 2024

metamaskbot commented Sep 21, 2024

plasmacorral commented Sep 28, 2024 •

edited

Loading

sahar-fehri commented Sep 29, 2024 •

edited

Loading

metamaskbot commented Sep 30, 2024

plasmacorral commented Oct 1, 2024

sonarcloud bot commented Oct 2, 2024

metamaskbot commented Oct 2, 2024

feat: aggregated balance feature #27097

feat: aggregated balance feature #27097

Conversation

sahar-fehri commented Sep 12, 2024 • edited Loading

Description

This final PR is the combination of the following PRs:

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 12, 2024

metamaskbot commented Sep 12, 2024

codecov bot commented Sep 12, 2024 • edited Loading

Codecov Report

metamaskbot commented Sep 13, 2024

sonarcloud bot commented Sep 17, 2024

Quality Gate passed

metamaskbot commented Sep 17, 2024

metamaskbot commented Sep 21, 2024

plasmacorral commented Sep 28, 2024 • edited Loading

sahar-fehri commented Sep 29, 2024 • edited Loading

metamaskbot commented Sep 30, 2024

plasmacorral commented Oct 1, 2024

sonarcloud bot commented Oct 2, 2024

Quality Gate passed

metamaskbot commented Oct 2, 2024

sahar-fehri commented Sep 12, 2024 •

edited

Loading

codecov bot commented Sep 12, 2024 •

edited

Loading

plasmacorral commented Sep 28, 2024 •

edited

Loading

sahar-fehri commented Sep 29, 2024 •

edited

Loading