feat: Redesigned Revoke setApprovalForAll confirmation #27111

pedronfigueiredo · 2024-09-12T16:36:57Z

Description

Includes modifiers to the setApprovalForAll screen to express revocation, including a new transaction simulation component. Includes e2e tests.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3005

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-09-12T16:37:10Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-09-12T17:11:27Z

Builds ready [9190a6a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2011 ± 237 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	359	3672	1899	607	291
		domContentLoaded	1412	3572	1982	495	238
		load	1446	3586	2011	494	237
		domInteractive	18	98	41	20	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 10.33 KiB (0.14%)
common: 572 Bytes (0.01%)

metamaskbot · 2024-09-18T14:32:52Z

Builds ready [d7e65fa]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1823 ± 97 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	228	2310	1601	588	283
		domContentLoaded	1477	2298	1794	209	100
		load	1543	2303	1823	203	97
		domInteractive	16	164	51	35	17

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 10.6 KiB (0.15%)
common: 572 Bytes (0.01%)

codecov · 2024-09-18T14:33:15Z

Codecov Report

Attention: Patch coverage is 68.57143% with 11 lines in your changes missing coverage. Please review.

Project coverage is 70.02%. Comparing base (7cce0ee) to head (afb5921).

Files with missing lines	Patch %	Lines
...s/confirmations/components/confirm/title/title.tsx	33.33%	8 Missing ⚠️
...pproval-for-all-info/set-approval-for-all-info.tsx	71.43%	2 Missing ⚠️
...ve-static-simulation/approve-static-simulation.tsx	75.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           pnf/2937   #27111      +/-   ##
============================================
- Coverage     70.03%   70.02%   -0.01%     
============================================
  Files          1445     1446       +1     
  Lines         50188    50211      +23     
  Branches      14048    14057       +9     
============================================
+ Hits          35145    35158      +13     
- Misses        15043    15053      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-09-19T13:38:39Z

Builds ready [afb5921]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1826 ± 136 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	217	2374	1583	600	288
		domContentLoaded	1437	2355	1808	282	136
		load	1446	2360	1826	283	136
		domInteractive	13	168	46	35	17

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 10.56 KiB (0.15%)
common: 572 Bytes (0.01%)

test/e2e/page-objects/pages/dialog.ts

...ions/components/confirm/info/approve/approve-static-simulation/approve-static-simulation.tsx

...oke-set-approval-for-all-static-simulation/revoke-set-approval-for-all-static-simulation.tsx

...onfirmations/components/confirm/info/set-approval-for-all-info/set-approval-for-all-info.tsx

...oke-set-approval-for-all-static-simulation/revoke-set-approval-for-all-static-simulation.tsx

...ges/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx

ui/pages/confirmations/components/confirm/title/title.tsx

sonarcloud · 2024-09-23T12:34:16Z

Quality Gate failed

Failed conditions
76.3% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

metamaskbot · 2024-09-24T12:38:40Z

Builds ready [f0faa44]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1874 ± 78 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1590	2183	1867	161	78
		domContentLoaded	1573	2108	1830	146	70
		load	1591	2182	1874	162	78
		domInteractive	14	181	42	36	17

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 5.8 KiB (0.08%)
common: 255 Bytes (0.00%)

pedronfigueiredo added the team-confirmations Push issues to confirmations team label Sep 12, 2024

pedronfigueiredo self-assigned this Sep 12, 2024

pedronfigueiredo requested review from a team as code owners September 12, 2024 16:36

pedronfigueiredo marked this pull request as draft September 12, 2024 16:38

pedronfigueiredo force-pushed the pnf/2937 branch from 1244155 to 4a0bd3a Compare September 12, 2024 16:49

pedronfigueiredo force-pushed the pnf/2937 branch 5 times, most recently from 70347a3 to f01b6c0 Compare September 18, 2024 13:06

pedronfigueiredo force-pushed the pnf/3005 branch from 9190a6a to 5eb91dc Compare September 18, 2024 13:28

pedronfigueiredo force-pushed the pnf/3005 branch from e51c167 to afb5921 Compare September 19, 2024 13:07

pedronfigueiredo marked this pull request as ready for review September 19, 2024 13:09

matthewwalsh0 requested changes Sep 19, 2024

View reviewed changes

pedronfigueiredo force-pushed the pnf/2937 branch from 718f1bb to 98ecbbd Compare September 20, 2024 10:44

pedronfigueiredo force-pushed the pnf/3005 branch from afb5921 to 450b528 Compare September 20, 2024 13:17

pedronfigueiredo force-pushed the pnf/2937 branch from 2df262f to d3c97af Compare September 20, 2024 16:03

pedronfigueiredo force-pushed the pnf/3005 branch from 0fb073a to 4e599e5 Compare September 20, 2024 16:51

pedronfigueiredo force-pushed the pnf/2937 branch 4 times, most recently from 6d267b0 to 717c4ff Compare September 23, 2024 17:37

Base automatically changed from pnf/2937 to develop September 24, 2024 09:07

pedronfigueiredo added 14 commits September 24, 2024 10:43

feat: Redesigned setApprovalForAll confirmations

1359dee

feat: Redesigned setApprovalForAll confirmations

bf22319

Migrate to Page Object Model

2a50886

fix linting errors

6c08813

Address feedback on POM

428a4f4

Rename setApprovalForAllTransactionConfirmation

0ee2f30

Ignore test folder in sonarqube

4c5fc85

Add unit test coverage

6b58db3

feat: Redesigned Revoke setApprovalForAll confirmation

c09f11c

Update snapshots

d9549a3

Migrate e2e tests to Page Object Model

8128691

Address feedback

bbdef9e

Address feedback

13e178b

WIP

143b96f

pedronfigueiredo force-pushed the pnf/3005 branch from 7a19e49 to 143b96f Compare September 24, 2024 10:08

pedronfigueiredo added 2 commits September 24, 2024 11:37

update snapshots

5393263

Fix linting error

f0faa44

pedronfigueiredo requested a review from matthewwalsh0 September 24, 2024 14:02

matthewwalsh0 approved these changes Sep 25, 2024

View reviewed changes

jpuri approved these changes Sep 25, 2024

View reviewed changes

pedronfigueiredo merged commit 470420f into develop Sep 25, 2024
75 of 76 checks passed

pedronfigueiredo deleted the pnf/3005 branch September 25, 2024 12:07

github-actions bot locked and limited conversation to collaborators Sep 25, 2024

metamaskbot added release-12.6.0 Issue or pull request that will be included in release 12.6.0 release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Redesigned Revoke setApprovalForAll confirmation #27111

feat: Redesigned Revoke setApprovalForAll confirmation #27111

pedronfigueiredo commented Sep 12, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024

metamaskbot commented Sep 12, 2024

metamaskbot commented Sep 18, 2024

codecov bot commented Sep 18, 2024 •

edited

Loading

metamaskbot commented Sep 19, 2024

sonarcloud bot commented Sep 23, 2024

metamaskbot commented Sep 24, 2024

feat: Redesigned Revoke setApprovalForAll confirmation #27111

feat: Redesigned Revoke setApprovalForAll confirmation #27111

Conversation

pedronfigueiredo commented Sep 12, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 12, 2024

metamaskbot commented Sep 12, 2024

metamaskbot commented Sep 18, 2024

codecov bot commented Sep 18, 2024 • edited Loading

Codecov Report

metamaskbot commented Sep 19, 2024

sonarcloud bot commented Sep 23, 2024

Quality Gate failed

metamaskbot commented Sep 24, 2024

pedronfigueiredo commented Sep 12, 2024 •

edited

Loading

codecov bot commented Sep 18, 2024 •

edited

Loading