Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dead code #27211

Merged

Conversation

cryptotavares
Copy link
Contributor

@cryptotavares cryptotavares commented Sep 17, 2024

Description

Removes unused code.

Open in GitHub Codespaces

Related issues

Fixes: None

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cryptotavares cryptotavares requested review from a team as code owners September 17, 2024 12:37
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot added the team-confirmations Push issues to confirmations team label Sep 17, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 17, 2024
Copy link

sonarcloud bot commented Sep 17, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [e86c861]
Page Load Metrics (1653 ± 104 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint23723041526473227
domContentLoaded139222841626212102
load145423041653217104
domInteractive1390412110
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.02%. Comparing base (e7df8e2) to head (e86c861).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #27211      +/-   ##
===========================================
+ Coverage    70.01%   70.02%   +0.01%     
===========================================
  Files         1445     1443       -2     
  Lines        50194    50166      -28     
  Branches     14041    14040       -1     
===========================================
- Hits         35139    35126      -13     
+ Misses       15055    15040      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cryptotavares cryptotavares merged commit bc4c4b1 into develop Sep 17, 2024
84 checks passed
@cryptotavares cryptotavares deleted the cryptotavares/remove-new-confirmations-dead-code branch September 17, 2024 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants