fix: [cherrypick][V12.3.0] permit single and batch simulation (3/3 permit simulation fix) #27212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erFrom simulation "Spending cap" (#26684) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> Fixes PermitSingle, PermitBatch, PermitTransferFrom, PermitBatchTransferFrom simulation to use their respective provided token and amount in token details. Additionally: - adjusts styles to have an 8px gap between each "Spending Cap" entry and right align content - create PermitSimulationValueDisplay component to separate individual token contract value logic - adds tests - adds sentry error to capture exception in case token isn't provided for the relevant primaryTypes dev note: majority of the newlines come from updated and new test snapshots [](https://codespaces.new/MetaMask/metamask-extension/pull/26684?quickstart=1) Fixes: #26591 (PermitSingle) Fixes: #26592 (PermitBatch) Test PermitSingle & PermitBatch with Improved Signature setting enabled See related issues for repro steps <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <img width="320" src="https://github.com/user-attachments/assets/aac7fa8c-285a-4d2b-bcec-84c7fc6245bf"> <!-- [screenshots/recordings] --> See Issue screenshots <!-- [screenshots/recordings] -->  - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
digiwand
added
team-confirmations
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
pedronfigueiredo
approved these changes
Sep 17, 2024
digiwand
changed the title
digiwand
changed the title
18 tasks
|
update - will not merge into 12.3 closing in favor of #27300 |
digiwand
deleted the
cherrypick-12.3.0-fix-permit-single-and-batch-simulation
branch
](https://codespaces.new/MetaMask/metamask-extension/pull/26684?quickstart=1){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-picks #26684 into V12.3.0
most conflicts pertain to tests
prerequisites before cherry-picking #26684
prerequisite 1: #27186
prerequisite 2: #27187
Related issues
Fixes: #26591 (PermitSingle)
Fixes: #26592 (PermitBatch)
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist