-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix ERC20 approve copy #27222
fix: Fix ERC20 approve copy #27222
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ef3db09
to
2626d7f
Compare
2626d7f
to
59927d1
Compare
Quality Gate passedIssues Measures |
Builds ready [59927d1]
Page Load Metrics (1919 ± 166 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #27222 +/- ##
===========================================
+ Coverage 70.03% 70.21% +0.18%
===========================================
Files 1443 1445 +2
Lines 50169 50143 -26
Branches 14041 14015 -26
===========================================
+ Hits 35131 35205 +74
+ Misses 15038 14938 -100 ☔ View full report in Codecov by Sentry. |
Missing release label release-12.5.0 on PR. Adding release label release-12.5.0 on PR and removing other release labels(release-12.6.0), as PR was added to branch 12.5.0 when release was cut. |
Description
Update two pieces of copy for the ERC20 Approve screen. The "Spender" field tooltip, as well as the simulation details description text.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist