-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade notification controllers #27224
feat: upgrade notification controllers #27224
Conversation
update notification-services and profile-sync to include user storage entry hash fix
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected] |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #27224 +/- ##
========================================
Coverage 70.02% 70.02%
========================================
Files 1443 1443
Lines 50162 50162
Branches 14039 14039
========================================
Hits 35124 35124
Misses 15038 15038 ☔ View full report in Codecov by Sentry. |
Builds ready [abaddd8]
Page Load Metrics (1908 ± 122 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YES!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Bumps:
@metamask/profile-sync-controller
from^0.7.0
to^0.8.0
@metamask/notification-services-controller
from^0.6.0
to^0.7.0
This fixes a critical issue where we were not using the same UserStorage hashed entry. See release library changelog
https://github.com/MetaMask/core/blob/main/packages/profile-sync-controller/CHANGELOG.md#fixed
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/NOTIFY-1118
Manual testing steps
Test notifications flow:
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist