Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade notification controllers #27224

Merged

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Sep 17, 2024

Description

Bumps:

  • @metamask/profile-sync-controller from ^0.7.0 to ^0.8.0
  • @metamask/notification-services-controller from ^0.6.0 to ^0.7.0

This fixes a critical issue where we were not using the same UserStorage hashed entry. See release library changelog
https://github.com/MetaMask/core/blob/main/packages/profile-sync-controller/CHANGELOG.md#fixed

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/NOTIFY-1118

Manual testing steps

Test notifications flow:

  • Enable/Disable Notifications

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

update notification-services and profile-sync to include user storage entry hash fix
@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner September 17, 2024 18:05
@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications Notifications team label Sep 17, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

Copy link

sonarcloud bot commented Sep 17, 2024

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.02%. Comparing base (bc4c4b1) to head (abaddd8).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #27224   +/-   ##
========================================
  Coverage    70.02%   70.02%           
========================================
  Files         1443     1443           
  Lines        50162    50162           
  Branches     14039    14039           
========================================
  Hits         35124    35124           
  Misses       15038    15038           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [abaddd8]
Page Load Metrics (1908 ± 122 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24028411662630303
domContentLoaded149126871871231111
load153828491908255122
domInteractive15245514723
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 21 Bytes (0.00%)
  • ui: 37 Bytes (0.00%)
  • common: 20.98 KiB (0.26%)

Copy link
Contributor

@mathieuartu mathieuartu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES!

Copy link
Contributor

@matteoscurati matteoscurati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Prithpal-Sooriya Prithpal-Sooriya merged commit c462fb8 into develop Sep 17, 2024
84 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the NOTIFY-1118/update-notification-controllers branch September 17, 2024 19:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-notifications Notifications team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants