-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Redesign Signature Message date values #27249
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
return DateTime.fromMillis(dateInMillis) | ||
.setZone('utc') | ||
return DateTime.fromSeconds(unixTimestamp) | ||
.toUTC() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.toUTC()
is equivalent to .setZone('utc')
Quality Gate passedIssues Measures |
Builds ready [1bdfda2]
Page Load Metrics (1759 ± 68 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Fix date values:
This PR fixes the conversion.
Related issues
Fixes: #27137
Manual testing steps
Screenshots/Recordings
Before
Test-dapp Permit
Deadline: -1
After
Test-dapp Permit
Deadline: -1
Pre-merge author checklist
Pre-merge reviewer checklist