Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add preinstalled example Snap #27271

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Sep 19, 2024

Description

This adds a preinstalled example Snap to the Flask build for testing purposes.

As requested by @legobeat I removed this change from #27057.

Open in GitHub Codespaces

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions github-actions bot added the team-snaps-platform Snaps Platform team label Sep 19, 2024
@Mrtenz Mrtenz changed the title Add preinstalled example Snap chore: Add preinstalled example Snap Sep 19, 2024
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 51.3 kB metamaskbot

View full report↗︎

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Sep 19, 2024
Copy link

sonarcloud bot commented Sep 19, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [90d7994]
Page Load Metrics (1602 ± 108 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint136823351596232112
domContentLoaded13612161156719996
load136622511602225108
domInteractive127632168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@Mrtenz Mrtenz marked this pull request as ready for review September 19, 2024 09:54
@Mrtenz Mrtenz requested review from a team as code owners September 19, 2024 09:54
@Mrtenz Mrtenz merged commit 27d8a54 into develop Sep 20, 2024
85 of 86 checks passed
@Mrtenz Mrtenz deleted the mrtenz/preinstalled-example-snap branch September 20, 2024 11:53
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants