Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: quality gate test coverage fix #27282

Merged
merged 32 commits into from
Sep 19, 2024
Merged

feat: quality gate test coverage fix #27282

merged 32 commits into from
Sep 19, 2024

Conversation

itsyoboieltr
Copy link
Contributor

@itsyoboieltr itsyoboieltr commented Sep 19, 2024

Description

Open in GitHub Codespaces

This PR fixes SonarCloud quality gate test coverage.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2962

Manual testing steps

  1. Test coverage is correctly reported, local coverage matches SonarCloud numbers.

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@itsyoboieltr itsyoboieltr self-assigned this Sep 19, 2024
@itsyoboieltr itsyoboieltr requested a review from a team as a code owner September 19, 2024 13:30
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

sonarcloud bot commented Sep 19, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [1df7d98]
Page Load Metrics (2078 ± 177 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint162532252075357171
domContentLoaded161132152048352169
load162232942078368177
domInteractive14128453014
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@itsyoboieltr itsyoboieltr merged commit 4a55b53 into develop Sep 19, 2024
77 checks passed
@itsyoboieltr itsyoboieltr deleted the quality-gate-test branch September 19, 2024 15:31
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants