Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add user-storage to privacy snapshot and update user-storage mocks #27292

Merged
merged 7 commits into from
Sep 23, 2024
Merged

feat: add user-storage to privacy snapshot and update user-storage mocks #27292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fcec986
test: add user-storage to privacy snapshot and update user-storage mocks
Prithpal-Sooriya Sep 19, 2024
552f88e
Merge branch 'develop' into test/fix-failing-user-storage-snapshot
Prithpal-Sooriya Sep 20, 2024
655d179
Merge branch 'develop' into test/fix-failing-user-storage-snapshot
Prithpal-Sooriya Sep 20, 2024
04bf9de
Merge branch 'develop' into test/fix-failing-user-storage-snapshot
Prithpal-Sooriya Sep 20, 2024
1897fad
Merge branch 'develop' into test/fix-failing-user-storage-snapshot
Prithpal-Sooriya Sep 20, 2024
4517e93
Merge branch 'develop' into test/fix-failing-user-storage-snapshot
Prithpal-Sooriya Sep 23, 2024
1829389
Merge branch 'develop' into test/fix-failing-user-storage-snapshot
Prithpal-Sooriya Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion privacy-snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,5 +58,6 @@
"oidc.api.cx.metamask.io",
"price.api.cx.metamask.io",
"token.api.cx.metamask.io",
"client-side-detection.api.cx.metamask.io"
"client-side-detection.api.cx.metamask.io",
"user-storage.api.cx.metamask.io"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API is now introduced in e2e tests as we have launched a new "Account Syncing" feature, which will sync your accounts you may have previously stored. This is done on wallet start/open post onboarding.

]
13 changes: 13 additions & 0 deletions test/e2e/tests/notifications/mocks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,19 @@ export async function mockNotificationServices(server: Mockttp) {
mockAPICall(server, await StorageMocks.getMockUserStorageGetResponse());
mockAPICall(server, await StorageMocks.getMockUserStoragePutResponse());

// TODO - add better mock responses for other Profile Sync features
// (Account Sync, Network Sync, ...)
Comment on lines +37 to +38
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we are currently mocking these API responses to fail fast. This ensures that the syncing features won't get in the way with existing e2e tests.

server
.forGet(/https:\/\/user-storage\.api\.cx\.metamask\.io\/.*/gu)
?.thenCallback(() => ({
statusCode: 404,
}));
server
.forPut(/https:\/\/user-storage\.api\.cx\.metamask\.io\/.*/gu)
?.thenCallback(() => ({
statusCode: 204,
}));

// Notifications
mockAPICall(server, NotificationMocks.getMockFeatureAnnouncementResponse());
mockAPICall(server, NotificationMocks.getMockBatchCreateTriggersResponse());
Expand Down