-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Ethereum logo to purple #27295
Merged
Merged
+9
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [02e325a]
Page Load Metrics (1775 ± 82 ms)
Bundle size diffs
|
amandaye0h
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm~
Builds ready [6b85209]
Page Load Metrics (1655 ± 86 ms)
Bundle size diffs
|
salimtb
approved these changes
Sep 20, 2024
Quality Gate passedIssues Measures |
metamaskbot
added
the
release-12.6.0
Issue or pull request that will be included in release 12.6.0
label
Sep 20, 2024
Builds ready [369473c]
Page Load Metrics (1661 ± 97 ms)
Bundle size diffs
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates ETH token and network icon to purple for better visibility on light mode.
Related issues
Issue: #26936
Jira: https://consensyssoftware.atlassian.net/browse/MMASSETS-378
Manual testing steps
Check to see that Ethereum token and network logos are the purple one
@amandaye0h the figma design logo had a white border. I modified the svg to remove this border, but can you please check that it looks alright to you?
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist