Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: network menu snaphots #27311

Merged
merged 523 commits into from
Sep 20, 2024
Merged

test: network menu snaphots #27311

merged 523 commits into from
Sep 20, 2024

Conversation

bergeron
Copy link
Contributor

@bergeron bergeron commented Sep 20, 2024

Description

Adds additional snapshots unit tests for the network form. And fixes the existing one. It was only snapshotting an empty <div />. Because of how modals work, you have to snapshot baseElement instead of container.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

bergeron and others added 30 commits August 25, 2024 13:28
@bergeron bergeron requested a review from a team as a code owner September 20, 2024 16:52
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Sep 20, 2024
Copy link

sonarcloud bot commented Sep 20, 2024

@bergeron bergeron merged commit f73aa77 into develop Sep 20, 2024
82 of 83 checks passed
@bergeron bergeron deleted the brian/network-unit-tests branch September 20, 2024 17:18
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 20, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [b7e57b8]
Page Load Metrics (1870 ± 144 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29425291719544261
domContentLoaded148524581850295142
load151025121870300144
domInteractive218043168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.6.0 Issue or pull request that will be included in release 12.6.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants