-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: network menu snaphots #27311
Merged
Merged
test: network menu snaphots #27311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… brian/network-controller-v20-merging-in-v21
…com:MetaMask/metamask-extension into brian/network-controller-v20-merging-in-v21
Co-authored-by: Maarten Zuidhoorn <[email protected]>
… brian/network-controller-v20-merging-in-v21
…com:MetaMask/metamask-extension into brian/network-controller-v20-merging-in-v21
… brian/network-controller-v20-merging-in-v21
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
bergeron
added
the
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
label
Sep 20, 2024
vinnyhoward
approved these changes
Sep 20, 2024
Quality Gate passedIssues Measures |
darkwing
approved these changes
Sep 20, 2024
metamaskbot
added
the
release-12.6.0
Issue or pull request that will be included in release 12.6.0
label
Sep 20, 2024
Builds ready [b7e57b8]
Page Load Metrics (1870 ± 144 ms)
Bundle size diffs
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
release-12.6.0
Issue or pull request that will be included in release 12.6.0
team-assets
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds additional snapshots unit tests for the network form. And fixes the existing one. It was only snapshotting an empty
<div />
. Because of how modals work, you have to snapshotbaseElement
instead ofcontainer
.Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist