Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get supportedChains to avoid blocking the confirmation process #28313

Merged
merged 15 commits into from
Nov 12, 2024

Commits on Nov 6, 2024

  1. Configuration menu
    Copy the full SHA
    484c07f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eaae019 View commit details
    Browse the repository at this point in the history
  3. fix e2e

    vinistevam committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    01585d0 View commit details
    Browse the repository at this point in the history
  4. fix e2e

    vinistevam committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    df1e50c View commit details
    Browse the repository at this point in the history
  5. fix e2e

    vinistevam committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    7b39e9e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    071863b View commit details
    Browse the repository at this point in the history
  7. fix e2e

    vinistevam committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    48d0796 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Configuration menu
    Copy the full SHA
    6d98182 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. apply suggestions

    vinistevam committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    4fba92d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3da82ec View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. fix e2e

    vinistevam committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    bcca3d4 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. applied suggestions

    vinistevam committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d906b7e View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. applied suggestions

    vinistevam committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    391feea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3fe3280 View commit details
    Browse the repository at this point in the history
  3. fix: use updateSecurityResponse (#28418)

    <!--
    Please submit this PR as a draft initially.
    Do not mark it as "Ready for review" until the template has been
    completely filled out, and PR status checks have passed at least once.
    -->
    
    ## **Description**
    
    <!--
    Write a short description of the changes included in this pull request,
    also include relevant motivation and context. Have in mind the following
    questions:
    1. What is the reason for the change?
    2. What is the improvement/solution?
    -->
    
    [![Open in GitHub
    Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28418?quickstart=1)
    
    ## **Related issues**
    
    Fixes:
    
    ## **Manual testing steps**
    
    1. Go to this page...
    2.
    3.
    
    ## **Screenshots/Recordings**
    
    <!-- If applicable, add screenshots and/or recordings to visualize the
    before and after of your change. -->
    
    ### **Before**
    
    <!-- [screenshots/recordings] -->
    
    ### **After**
    
    <!-- [screenshots/recordings] -->
    
    ## **Pre-merge author checklist**
    
    - [ ] I've followed [MetaMask Contributor
    Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
    Extension Coding
    Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
    - [ ] I've completed the PR template to the best of my ability
    - [ ] I’ve included tests if applicable
    - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
    if applicable
    - [ ] I’ve applied the right labels on the PR (see [labeling
    guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
    Not required for external contributors.
    
    ## **Pre-merge reviewer checklist**
    
    - [ ] I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
    - [ ] I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.
    vinistevam authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    d850354 View commit details
    Browse the repository at this point in the history