-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get supportedChains
to avoid blocking the confirmation process
#28313
Merged
Commits on Nov 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 484c07f - Browse repository at this point
Copy the full SHA 484c07fView commit details -
Configuration menu - View commit details
-
Copy full SHA for eaae019 - Browse repository at this point
Copy the full SHA eaae019View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01585d0 - Browse repository at this point
Copy the full SHA 01585d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for df1e50c - Browse repository at this point
Copy the full SHA df1e50cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b39e9e - Browse repository at this point
Copy the full SHA 7b39e9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 071863b - Browse repository at this point
Copy the full SHA 071863bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48d0796 - Browse repository at this point
Copy the full SHA 48d0796View commit details
Commits on Nov 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6d98182 - Browse repository at this point
Copy the full SHA 6d98182View commit details
Commits on Nov 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4fba92d - Browse repository at this point
Copy the full SHA 4fba92dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3da82ec - Browse repository at this point
Copy the full SHA 3da82ecView commit details
Commits on Nov 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bcca3d4 - Browse repository at this point
Copy the full SHA bcca3d4View commit details
Commits on Nov 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d906b7e - Browse repository at this point
Copy the full SHA d906b7eView commit details
Commits on Nov 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 391feea - Browse repository at this point
Copy the full SHA 391feeaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fe3280 - Browse repository at this point
Copy the full SHA 3fe3280View commit details -
fix: use
updateSecurityResponse
(#28418)<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/28418?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Configuration menu - View commit details
-
Copy full SHA for d850354 - Browse repository at this point
Copy the full SHA d850354View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.