fix: fix network client ID used on the useGasFeeInputs hook #28391

salimtb · 2024-11-08T18:30:09Z

Description

When I delete Sepolia and re-add it again I get the error No Infura network client was found with the ID "sepolia".
The requests are working normally

Related issues

Fixes: #28263 #28247

Manual testing steps

process transaction using sepolia
delete sepolia network
add it and go to activity tab

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-11-08T18:30:20Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

ui/pages/confirmations/hooks/useGasFeeInputs.js

metamaskbot · 2024-11-08T21:10:47Z

Builds ready [dbd2e9d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1858 ± 82 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1677	2202	1862	168	81
		domContentLoaded	1663	2148	1826	161	77
		load	1675	2205	1858	170	82
		domInteractive	26	167	48	34	17
		backgroundConnect	11	75	29	19	9
		firstReactRender	54	201	101	31	15
		getState	5	65	17	17	8
		initialActions	0	1	0	0	0
		loadScripts	1203	1695	1362	153	73
		setupStore	6	50	11	12	6
		uiStartup	1861	2401	2058	172	82

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 232 Bytes (0.00%)
common: 0 Bytes (0.00%)

bergeron · 2024-11-08T21:38:58Z

This looks like it also resolves #28247

ui/pages/confirmations/hooks/useGasFeeInputs.js

metamaskbot · 2024-11-09T12:19:35Z

Builds ready [2a5810e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1652 ± 47 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	251	1996	1598	323	155
		domContentLoaded	1537	1919	1621	86	41
		load	1544	2000	1652	98	47
		domInteractive	24	75	39	14	7
		backgroundConnect	10	83	35	21	10
		firstReactRender	77	193	96	23	11
		getState	4	48	10	10	5
		initialActions	0	1	0	0	0
		loadScripts	1095	1370	1181	66	32
		setupStore	5	52	9	10	5
		uiStartup	1684	2229	1828	125	60

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 258 Bytes (0.00%)
common: 0 Bytes (0.00%)

ui/pages/confirmations/hooks/useGasFeeInputs.js

ui/pages/confirmations/hooks/useGasFeeInputs.test.js

metamaskbot · 2024-11-12T12:06:31Z

Builds ready [69ba896]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2242 ± 166 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1769	3259	2239	345	166
		domContentLoaded	1760	3152	2191	334	160
		load	1772	3255	2242	346	166
		domInteractive	27	109	60	25	12
		backgroundConnect	10	183	53	42	20
		firstReactRender	97	294	134	53	25
		getState	5	47	14	9	4
		initialActions	0	1	0	0	0
		loadScripts	1204	2284	1625	268	129
		setupStore	6	68	14	15	7
		uiStartup	1973	3852	2510	414	199

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 220 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-11-12T17:53:16Z

Builds ready [7f37efe]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2347 ± 344 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	501	3558	1987	700	336
		domContentLoaded	1763	4985	2314	710	341
		load	1771	5010	2347	716	344
		domInteractive	25	123	63	25	12
		backgroundConnect	7	102	38	28	13
		firstReactRender	87	295	130	54	26
		getState	4	70	26	22	11
		initialActions	0	0	0	0	0
		loadScripts	1259	3991	1720	574	275
		setupStore	6	62	17	15	7
		uiStartup	1994	5714	2639	831	399

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 220 Bytes (0.00%)
common: 0 Bytes (0.00%)

salimtb force-pushed the salim/fix-network-client-id-used branch from 8f56d63 to 75ea78a Compare November 8, 2024 18:31

salimtb commented Nov 8, 2024

View reviewed changes

ui/pages/confirmations/hooks/useGasFeeInputs.js Show resolved Hide resolved

salimtb added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. asset-metadata Issues with asset metadata like prices, images regression-RC-12.7.0 labels Nov 8, 2024

salimtb force-pushed the salim/fix-network-client-id-used branch from 75ea78a to 7c08d20 Compare November 8, 2024 19:55

salimtb added team-assets and removed asset-metadata Issues with asset metadata like prices, images labels Nov 8, 2024

salimtb marked this pull request as ready for review November 8, 2024 19:58

salimtb requested a review from a team as a code owner November 8, 2024 19:58

salimtb marked this pull request as draft November 8, 2024 20:01

fix: fix network client ID used on the useGasFeeInputs hook

dbd2e9d

salimtb force-pushed the salim/fix-network-client-id-used branch from 7c08d20 to dbd2e9d Compare November 8, 2024 20:37

salimtb marked this pull request as ready for review November 8, 2024 20:46

bergeron reviewed Nov 8, 2024

View reviewed changes

ui/pages/confirmations/hooks/useGasFeeInputs.js Outdated Show resolved Hide resolved

fix: fix PR comment

2a5810e

OGPoyraz reviewed Nov 11, 2024

View reviewed changes

ui/pages/confirmations/hooks/useGasFeeInputs.js Outdated Show resolved Hide resolved

OGPoyraz reviewed Nov 11, 2024

View reviewed changes

ui/pages/confirmations/hooks/useGasFeeInputs.test.js Show resolved Hide resolved

OGPoyraz reviewed Nov 11, 2024

View reviewed changes

ui/pages/confirmations/hooks/useGasFeeInputs.test.js Outdated Show resolved Hide resolved

salimtb added 2 commits November 12, 2024 12:27

fix: fix PR comments

13ef028

Merge branch 'develop' into salim/fix-network-client-id-used

69ba896

salimtb requested review from OGPoyraz and bergeron November 12, 2024 14:22

Prithpal-Sooriya approved these changes Nov 12, 2024

View reviewed changes

Merge branch 'develop' into salim/fix-network-client-id-used

e97cdba

NidhiKJha approved these changes Nov 12, 2024

View reviewed changes

OGPoyraz approved these changes Nov 12, 2024

View reviewed changes

Merge branch 'develop' into salim/fix-network-client-id-used

7f37efe

salimtb added this pull request to the merge queue Nov 12, 2024

Merged via the queue into develop with commit 36cee88 Nov 12, 2024
76 checks passed

salimtb deleted the salim/fix-network-client-id-used branch November 12, 2024 18:19

github-actions bot locked and limited conversation to collaborators Nov 12, 2024

metamaskbot added the release-12.8.0 Issue or pull request that will be included in release 12.8.0 label Nov 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fix network client ID used on the useGasFeeInputs hook #28391

fix: fix network client ID used on the useGasFeeInputs hook #28391

salimtb commented Nov 8, 2024 •

edited

Loading

github-actions bot commented Nov 8, 2024

metamaskbot commented Nov 8, 2024

bergeron commented Nov 8, 2024

metamaskbot commented Nov 9, 2024

metamaskbot commented Nov 12, 2024

metamaskbot commented Nov 12, 2024

fix: fix network client ID used on the useGasFeeInputs hook #28391

fix: fix network client ID used on the useGasFeeInputs hook #28391

Conversation

salimtb commented Nov 8, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Nov 8, 2024

metamaskbot commented Nov 8, 2024

bergeron commented Nov 8, 2024

metamaskbot commented Nov 9, 2024

metamaskbot commented Nov 12, 2024

metamaskbot commented Nov 12, 2024

salimtb commented Nov 8, 2024 •

edited

Loading