Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide network picker back button when network is unselected #29711

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Jan 14, 2025

Description

This hides the network picker's back button when there's no selected network. Currently this causes the dest network picker to navigate to the src asset picker

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1852

Manual testing steps

  1. Load bridge page
  2. Open dest asset picker
  3. Verify that back button is not visible

Screenshots/Recordings

Before

Screen.Recording.2025-01-21.at.12.26.52.PM.mov

After

Screen.Recording.2025-01-21.at.12.27.33.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@metamaskbot
Copy link
Collaborator

Builds ready [d1b7579]
Page Load Metrics (1513 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1385168915159144
domContentLoaded1378167414908842
load1387168715139144
domInteractive239038199
backgroundConnect583232210
firstReactRender15102573014
getState581172311
initialActions01000
loadScripts993129711118340
setupStore58610178
uiStartup15502280184720598
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 12 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae force-pushed the mms1852-rm-network-picker-back-button branch from d1b7579 to a4e168e Compare January 16, 2025 23:38
@metamaskbot
Copy link
Collaborator

Builds ready [a4e168e]
Page Load Metrics (1844 ± 157 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31826051782467224
domContentLoaded146025421822322155
load147125941844326157
domInteractive22100512412
backgroundConnect98523199
firstReactRender1678402311
getState56224209
initialActions00000
loadScripts107920381371280135
setupStore67117209
uiStartup164429292095363174
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 12 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae force-pushed the mms1852-rm-network-picker-back-button branch from a4e168e to 76a5638 Compare January 21, 2025 20:23
@micaelae micaelae marked this pull request as ready for review January 21, 2025 20:28
@micaelae micaelae requested a review from a team as a code owner January 21, 2025 20:28
@metamaskbot
Copy link
Collaborator

Builds ready [76a5638]
Page Load Metrics (1627 ± 30 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1485175316276330
domContentLoaded1475173816075828
load1486175316276230
domInteractive2496432110
backgroundConnect65424157
firstReactRender1596382713
getState459182010
initialActions01000
loadScripts1083130011935124
setupStore6471094
uiStartup17262361189213967
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 12 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 014c9dc Jan 31, 2025
75 checks passed
@micaelae micaelae deleted the mms1852-rm-network-picker-back-button branch January 31, 2025 01:24
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-bridge
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants