Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: font size and extension dimensions update (WIP) #29937

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Jan 28, 2025

Description

This PR updates the MetaMask extension's default typography and dimensions to improve readability and provide more space for content:

  1. Typography Changes:

    • Updates the Text component to use large typography variables by default (16px font size). Note that this does not update all typography—any static SCSS using font-size will remain unchanged.
    • Removes the responsive typography behavior, standardizing on the larger size across all screen sizes
    • This change will make text more readable across the extension
  2. Extension Dimension Updates:

    • Increases the extension width from 357px to 400px
    • Updates this dimension across multiple files including popup windows, modals, and UI components
    • Provides more horizontal space for content while maintaining the height at 600px also allows for larger font size

These changes are part of our efforts to improve the overall user experience and readability of the MetaMask extension.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3997

Manual testing steps

  1. Build and run the extension locally or download the build
  2. Verify the extension popup opens at 400px width
  3. Check various text components to ensure they're using the larger typography
  4. Verify modals and other UI components properly adjust to the new width
  5. Test across different pages (unlock page, main wallet view, etc.) to ensure consistent sizing

Screenshots/Recordings

Before

  • Extension width: 357px
  • Smaller default typography with responsive scaling
before.extension720.mov

After

  • Extension width: 400px
  • Larger, consistent typography (16px base size)
extension.after.mov

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards
  • I've completed the PR template to the best of my ability
  • I've included tests if applicable
  • I've documented my code using JSDoc format if applicable
  • I've applied the right labels on the PR

Pre-merge reviewer checklist

  • I've manually tested the PR
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots

@georgewrmarshall georgewrmarshall added DO-NOT-MERGE Pull requests that should not be merged team-design-system All issues relating to design system in Extension labels Jan 28, 2025
@georgewrmarshall georgewrmarshall self-assigned this Jan 28, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO-NOT-MERGE Pull requests that should not be merged team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant