Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @metamask/eth-hd-keyring #29961

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikesposito
Copy link
Member

@mikesposito mikesposito commented Jan 29, 2025

Description

This is a work in progress PR meant to test changes being made on @metamask/eth-hd-keyring: MetaMask/accounts#166

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask-previews/[email protected] None 0 132 kB metamaskbot

View full report↗︎

@metamaskbot
Copy link
Collaborator

Builds ready [7f65a88]
Page Load Metrics (1591 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint13361897158913665
domContentLoaded13291869156413263
load13371904159114369
domInteractive2287422210
backgroundConnect97126199
firstReactRender1491342612
getState480212412
initialActions00000
loadScripts9401366113211455
setupStore68014178
uiStartup15422318183319794
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 96.1 KiB (1.63%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants