fix: Clicking on report link does not add external_link_clicked to si…

[pnarayanaswamy]

…gnature events

Description

Fixes the bug that the external_link_clicked property is not added to the Signature approved, signature rejected , transaction approved and transaction rejected events
Adds integration tests to verify the property is added to the metrics

Related issues

Fixes: #23995

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [b22bea6]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1619 ± 44 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	466	1770	1564	266	128
		domContentLoaded	1435	1718	1591	88	42
		load	1445	1768	1619	91	44
		domInteractive	23	78	42	21	10
		backgroundConnect	8	61	24	18	9
		firstReactRender	15	99	37	28	14
		getState	4	71	16	18	9
		initialActions	0	0	0	0	0
		loadScripts	1020	1303	1166	81	39
		setupStore	7	81	17	21	10
		uiStartup	1667	2432	1903	212	102

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 399 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [a3f8f6d]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1705 ± 74 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	300	2066	1643	342	164
		domContentLoaded	1465	2056	1682	147	71
		load	1474	2069	1705	155	74
		domInteractive	23	171	45	33	16
		backgroundConnect	8	87	27	24	12
		firstReactRender	15	100	41	27	13
		getState	4	56	15	17	8
		initialActions	0	1	0	0	0
		loadScripts	1034	1510	1216	110	53
		setupStore	6	80	15	18	9
		uiStartup	1701	2440	1959	199	96

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 667 Bytes (0.01%)
• common: 0 Bytes (0.00%)