Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch quotes when src amount's decimals are greater than token's #29990

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Jan 30, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/MMS-1840

Manual testing steps

  1. Select optimism USDC as src token
  2. Select Polygon USDC as destination
  3. Type in 10.0000007
  4. Quotes should be fetched
  5. Try typing/pasting in other invalid inputs like 1abc,. or .1.1.1
  6. Input field should only reflect valid parts of the amount

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae force-pushed the mms1840-no-quotes-for-decimals branch from 625c9cf to 39fbe7b Compare January 30, 2025 00:57
@micaelae micaelae changed the title fix: src amount validation and quote fetching fix: bridge src amount validation prevents quotes from being fetched Jan 30, 2025
@micaelae micaelae marked this pull request as ready for review January 30, 2025 01:34
@micaelae micaelae requested a review from a team as a code owner January 30, 2025 01:34
@micaelae micaelae changed the title fix: bridge src amount validation prevents quotes from being fetched fix: fetch quotes when src amount's decimals are greater than token's Jan 30, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [39fbe7b]
Page Load Metrics (1725 ± 80 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14472163172616780
domContentLoaded14362106169215775
load14482165172516780
domInteractive26108442411
backgroundConnect1283362512
firstReactRender1696442612
getState56517189
initialActions00000
loadScripts10451645125314168
setupStore76617199
uiStartup16062406200120498
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 292 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants