Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Makes NFT list properly wrap within the send modal #30005

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Jan 30, 2025

Description

Wraps the NFT list within the Send flow such that it will not overflow

Open in GitHub Codespaces

Related issues

Fixes: #29974

Manual testing steps

  1. Use an account with many NFTs
  2. Start send flow
  3. Click the AssetPicker, choose NFTs
  4. See the wrapped NFTs

Screenshots/Recordings

Before

After

SCR-20250130-hbwm

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-assets labels Jan 30, 2025
@sahar-fehri sahar-fehri changed the title Fix: #29974 - Makes NFT list properly wrap within the send modal Fix: Makes NFT list properly wrap within the send modal Jan 30, 2025
@sahar-fehri sahar-fehri changed the title Fix: Makes NFT list properly wrap within the send modal fix: Makes NFT list properly wrap within the send modal Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: [Bug]: In the NFT view within the Send flow, the token assets are displayed only partially
3 participants