Version v12.12.0 RC

.depcheckrc.yml

@@ -24,7 +24,7 @@ ignores:
   - '@metamask/phishing-warning' # statically hosted as part of some e2e tests
   - '@metamask/test-dapp'
   - '@metamask/design-tokens' # Only imported in index.css
-  - '@tsconfig/node20' # required dynamically by TS, used in tsconfig.json
+  - '@tsconfig/node22' # required dynamically by TS, used in tsconfig.json
   - '@sentry/cli' # invoked as `sentry-cli`
   - 'chromedriver'
   - 'depcheck' # ooo meta

.eslintrc.js

@@ -308,7 +308,6 @@ module.exports = {
       files: [
         '**/__snapshots__/*.snap',
         'app/scripts/controllers/app-state-controller.test.ts',
-        'app/scripts/controllers/mmi-controller.test.ts',
         'app/scripts/controllers/alert-controller.test.ts',
         'app/scripts/metamask-controller.actions.test.js',
         'app/scripts/detect-multiple-instances.test.js',

.github/CODEOWNERS

@@ -13,7 +13,7 @@
 # audit these changes on their own, and leave their analysis in a comment.
 # These codeowners will review this analysis, and review the policy changes in
 # further detail if warranted.
-lavamoat/                            @MetaMask/extension-devs @MetaMask/supply-chain
+lavamoat/                            @MetaMask/extension-devs @MetaMask/policy-reviewers @MetaMask/supply-chain
 
 # The offscreen.ts script file that is included in the offscreen document html
 # file is responsible, at present, for loading the snaps execution environment
@@ -56,18 +56,13 @@ privacy-snapshot.json                @MetaMask/extension-privacy-reviewers
 .devcontainer/                       @MetaMask/extension-security-team @HowardBraham
 
 # Confirmations team to own code for confirmations on UI.
-app/scripts/lib/ppom                    @MetaMask/confirmations
-app/scripts/lib/signature               @MetaMask/confirmations
-app/scripts/lib/transaction/decode      @MetaMask/confirmations
-app/scripts/lib/transaction/metrics.*   @MetaMask/confirmations
-app/scripts/lib/transaction/util.*      @MetaMask/confirmations
-ui/pages/confirmations                  @MetaMask/confirmations
-
-# MMI team is responsible for code related with Institutioanl version of MetaMask
-ui/pages/institutional               @MetaMask/mmi
-ui/components/institutional          @MetaMask/mmi
-ui/ducks/institutional               @MetaMask/mmi
-ui/selectors/institutional           @MetaMask/mmi
+app/scripts/controller-init/confirmations                         @MetaMask/confirmations
+app/scripts/lib/ppom                                              @MetaMask/confirmations
+app/scripts/lib/signature                                         @MetaMask/confirmations
+app/scripts/lib/transaction/decode                                @MetaMask/confirmations
+app/scripts/lib/transaction/metrics.*                             @MetaMask/confirmations
+app/scripts/lib/transaction/util.*                                @MetaMask/confirmations
+ui/pages/confirmations                                            @MetaMask/confirmations
 
 # Design System to own code for the component-library folder
 # Slack handle: @metamask-design-system-team | Slack channel: #metamask-design-system

.github/workflows/build-beta.yml

@@ -0,0 +1,78 @@
+name: Build beta
+
+on:
+  workflow_call:
+
+jobs:
+  build-beta:
+    name: Build beta
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          # By default, the checkout action checks out the last merge commit for pull requests.
+          # Source: https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request
+          # However, we need the head commit (the latest commit pushed to the source branch)
+          # because in the workflow, we would like to parse the latest commit message.
+          # Specifying `ref` ensures that the head commit is checked out directly.
+          # For a `pull_request` event, the head commit hash is `github.event.pull_request.head.sha`.
+          # For a `push` event, the head commit hash is `github.sha`.
+          ref: ${{ github.event.pull_request.head.sha || github.sha }}
+
+      - name: Needs beta build
+        # For a `pull_request` event, the branch is `github.head_ref``.
+        # For a `push` event, the branch is `github.ref_name`.
+        if: ${{ (github.head_ref || github.ref_name) != 'master' }}
+        id: needs-beta-build
+        env:
+          BRANCH: ${{ github.head_ref || github.ref_name }}
+        run: |
+          version="${BRANCH/Version-v/}"
+          commit_message=$(git show -s --format=%s HEAD)
+          beta_version_regex="Version v[0-9]+\.[0-9]+\.[0-9]+-beta\.[0-9]+"
+
+          if [[ "$commit_message" =~ $beta_version_regex ]]; then
+              printf '%s\n' "Creating a build for $version with $commit_message"
+              echo "NEEDS_BETA_BUILD=true" >> "$GITHUB_OUTPUT"
+          else
+              printf '%s\n' 'Commit message does not match commit message for beta pattern; skipping beta build'
+              echo "NEEDS_BETA_BUILD=false" >> "$GITHUB_OUTPUT"
+          fi
+
+      - name: Setup environment
+        if: ${{ steps.needs-beta-build.outputs.NEEDS_BETA_BUILD == 'true' }}
+        uses: metamask/github-tools/.github/actions/setup-environment@main
+
+      - name: Run beta build
+        if: ${{ steps.needs-beta-build.outputs.NEEDS_BETA_BUILD == 'true' }}
+        env:
+          INFURA_PROJECT_ID: 00000000000
+          INFURA_BETA_PROJECT_ID: 00000000000
+          SEGMENT_BETA_WRITE_KEY: 00000000000
+          ENABLE_MV3: true
+        run: |
+          yarn build --build-type beta --platform='chrome' dist
+          yarn build --build-type beta --platform='chrome' prod
+
+      - name: Validate source maps
+        if: ${{ steps.needs-beta-build.outputs.NEEDS_BETA_BUILD == 'true' }}
+        run: yarn validate-source-maps
+
+      - name: Upload 'dist-beta' to S3
+        if: ${{ steps.needs-beta-build.outputs.NEEDS_BETA_BUILD == 'true' }}
+        uses: metamask/github-tools/.github/actions/upload-s3@1233659b3850eb84824d7375e2e0c58eb237701d
+        with:
+          aws-region: ${{ vars.AWS_REGION }}
+          role-to-assume: ${{ vars.AWS_IAM_ROLE }}
+          s3-bucket: ${{ vars.AWS_S3_BUCKET }}/${{ github.event.repository.name }}/${{ github.run_id }}/dist-beta
+          path: dist
+
+      - name: Upload 'builds-beta' to S3
+        if: ${{ steps.needs-beta-build.outputs.NEEDS_BETA_BUILD == 'true' }}
+        uses: metamask/github-tools/.github/actions/upload-s3@1233659b3850eb84824d7375e2e0c58eb237701d
+        with:
+          aws-region: ${{ vars.AWS_REGION }}
+          role-to-assume: ${{ vars.AWS_IAM_ROLE }}
+          s3-bucket: ${{ vars.AWS_S3_BUCKET }}/${{ github.event.repository.name }}/${{ github.run_id }}/builds-beta
+          path: builds

.github/workflows/build-storybook.yml

@@ -0,0 +1,37 @@
+name: Build storybook
+
+on:
+  workflow_call:
+    secrets:
+      STORYBOOK_TOKEN:
+        required: true
+
+jobs:
+  build-storybook:
+    name: Build storybook
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Setup environment
+        uses: metamask/github-tools/.github/actions/setup-environment@main
+
+      - name: Build storybook
+        run: yarn storybook:build
+
+      - name: Upload 'storybook-build' to S3
+        uses: metamask/github-tools/.github/actions/upload-s3@1233659b3850eb84824d7375e2e0c58eb237701d
+        with:
+          aws-region: ${{ vars.AWS_REGION }}
+          role-to-assume: ${{ vars.AWS_IAM_ROLE }}
+          s3-bucket: ${{ vars.AWS_S3_BUCKET }}/${{ github.event.repository.name }}/${{ github.run_id }}/storybook-build
+          path: storybook-build
+
+      - name: Deploy storybook
+        # For a `pull_request` event, the branch is `github.head_ref``.
+        # For a `push` event, the branch is `github.ref_name`.
+        if: ${{ (github.head_ref || github.ref_name) == 'main' }}
+        run: |
+          git remote add storybook https://${{ secrets.STORYBOOK_TOKEN }}@github.com/MetaMask/metamask-storybook.git
+          yarn storybook:deploy